Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code in glyph drawing code #128

Merged
merged 1 commit into from
Jan 27, 2024

Commits on Jan 27, 2024

  1. Remove unused code in glyph drawing code

    The original intent of the `when` block was to remove the line around the
    glyph when the line and fill color were the same. However, the `eq?` test was
    always false in Typed Racket, so the code never executed.
    
    The `eq?` test is now fixed in
    racket/typed-racket#1358, but as a result, the visual
    layout of plots would change, making glyphs smaller, since the outline is not
    drawn anymore.
    
    To keep the backwards compatibility of the plot look-and-feel, the entire
    `when` block was removed.
    alex-hhh committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    89eaa6e View commit details
    Browse the repository at this point in the history