Points: introductory flow #5201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benisgold
changed the base branch from
develop
to
@benisgold/points-tab-data
benisgold
changed the title
benisgold
commented
Nov 30, 2023
| @@ -46,7 +46,7 @@ | |||
| android:exported="true" | |||
| android:configChanges="keyboard|keyboardHidden|orientation|screenSize|smallestScreenSize|uiMode" | |||
| android:launchMode="singleTask" | |||
| android:windowSoftInputMode="adjustResize"> | |||
There was a problem hiding this comment.
so keyboard doesn't push up tab bar on android
There was a problem hiding this comment.
should take a look at how this impacts the send flow
benisgold
commented
Nov 30, 2023
src/components/icons/TabBarIcon.tsx
Outdated
| @@ -126,7 +126,13 @@ export function TabBarIcon({ | |||
| const backgroundColor = interpolateColor( | |||
| reanimatedPosition.value, | |||
| [index - 0.7, index - 0.3, index, index + 0.3, index + 0.7], | |||
| [accentColor, accentColor, accentColor, accentColor, accentColor] | |||
| [ | |||
| accentColor ?? colors.appleBlue, | |||
There was a problem hiding this comment.
was causing some crashes in the case that accentColor did not exist
benisgold
commented
Nov 30, 2023
| @@ -122,197 +122,205 @@ const TabBar = ({ | |||
| // ], | |||
| // }; | |||
| // }); | |||
|
|
|||
| const ShadowWrapper = ({ children }) => { | |||
There was a problem hiding this comment.
not sure why this file's formatting changed so much, but this ShadowWrapper is the only change. prevents tab bar from being unresponsive in points tab.
…ow-me/rainbow into @benisgold/points-signing
benisgold
changed the title
skylarbarrera
approved these changes
Dec 1, 2023
| @@ -46,7 +46,7 @@ | |||
| android:exported="true" | |||
| android:configChanges="keyboard|keyboardHidden|orientation|screenSize|smallestScreenSize|uiMode" | |||
| android:launchMode="singleTask" | |||
| android:windowSoftInputMode="adjustResize"> | |||
There was a problem hiding this comment.
should take a look at how this impacts the send flow
src/graphql/config.js
Outdated
| @@ -10,7 +10,7 @@ exports.config = { | |||
| metadata: { | |||
| __name: 'metadata', | |||
| document: './queries/metadata.graphql', | |||
| schema: { method: 'GET', url: 'https://metadata.p.rainbow.me/v1/graph' }, | |||
| schema: { method: 'POST', url: 'https://metadata.p.rainbow.me/v1/graph' }, | |||
There was a problem hiding this comment.
afaik we should be using POST for all metadata calls, if you need to use POST feel free to rename the simulation config to something more generic and use that for points
iirc POST messes with cloudflare caching so we should only use where necessary
There was a problem hiding this comment.
ok cool thanks for the info. renamed simulation/simulationClient to metadataPOST/metadataPOSTClient
| {avatarURL ? ( | ||
| <Box | ||
| as={Image} | ||
| source={{ uri: maybeSignUri(avatarURL) }} |
There was a problem hiding this comment.
should pop a width on this so its resized just in case
| | ||
| </Text> | ||
| <Text color="labelQuaternary" size="13pt" weight="semibold"> | ||
| {`40 ${i18n.t(i18n.l.points.points.days)}`} |
There was a problem hiding this comment.
prob will want to change this hardcoded value if were using a remote flag
There was a problem hiding this comment.
removed this in follow up pr that i'm working on
| addressCopiedToastAtom | ||
| ); | ||
|
|
||
| useFocusEffect( |
There was a problem hiding this comment.
I dont think we need this here
There was a problem hiding this comment.
logic doenst make sense maybe from previous testing?
There was a problem hiding this comment.
yeah no longer needed
| }, 2000); | ||
| } | ||
| onNewEmoji(); | ||
| setClipboard(accountAddress); |
There was a problem hiding this comment.
shouldn't this be referral code? also curious id this maybe should copy the full link vs just the code
There was a problem hiding this comment.
fixed this in follow up pr that i'm working on
| weight="semibold" | ||
| numberOfLines={1} | ||
| > | ||
| rainbow.me/points?ref=0x2e6786983232jkl |
There was a problem hiding this comment.
removed this in follow up pr that i'm working on
* Add SF Mono, SF Pro Rounded Black * Add AnimatePresence * Update green/red colors * Add ConsoleSheet * Hook up iOS fonts * Hook up to PointsScreen * Style fixes * hook up some logic to claim signing * no retroactive points ui * fix points content layout * fix * i18n * fix error logging --------- Co-authored-by: Christian Baroni <[email protected]>
benisgold
force-pushed
the
@benisgold/points-signing
branch
from
9e0a358 to
3fbbf9b
Compare
benisgold
added a commit
that referenced
this pull request
Dec 1, 2023
* points hook * some error state + pull to refresh * fix copy haptic + pull to refresh * fix * Points: introductory flow (#5201) * refactor * claim logic * mutation * claim content * referral screen * referral ui * temp * fix android input and tabs * fix animation + back button android * layout fixes * final fixes + i18n * Points: signing up (#5210) * Add SF Mono, SF Pro Rounded Black * Add AnimatePresence * Update green/red colors * Add ConsoleSheet * Hook up iOS fonts * Hook up to PointsScreen * Style fixes * hook up some logic to claim signing * no retroactive points ui * fix points content layout * fix * i18n * fix error logging --------- Co-authored-by: Christian Baroni <[email protected]> * remove obsolete useFocusEffect * ImgixImage * simulationClient -> metadataPOSTClient --------- Co-authored-by: Christian Baroni <[email protected]> --------- Co-authored-by: Christian Baroni <[email protected]>
skylarbarrera
added a commit
that referenced
this pull request
Dec 11, 2023
* points tab ui * i18n * fix * fix android * android fix * Points: hook up points tab ui to metadata api (#5176) * points hook * some error state + pull to refresh * fix copy haptic + pull to refresh * fix * Points: introductory flow (#5201) * refactor * claim logic * mutation * claim content * referral screen * referral ui * temp * fix android input and tabs * fix animation + back button android * layout fixes * final fixes + i18n * Points: signing up (#5210) * Add SF Mono, SF Pro Rounded Black * Add AnimatePresence * Update green/red colors * Add ConsoleSheet * Hook up iOS fonts * Hook up to PointsScreen * Style fixes * hook up some logic to claim signing * no retroactive points ui * fix points content layout * fix * i18n * fix error logging --------- Co-authored-by: Christian Baroni <[email protected]> * remove obsolete useFocusEffect * ImgixImage * simulationClient -> metadataPOSTClient --------- Co-authored-by: Christian Baroni <[email protected]> --------- Co-authored-by: Christian Baroni <[email protected]> * merge fix * Points fixes (#5219) * points hook * some error state + pull to refresh * fix copy haptic + pull to refresh * refactor * claim logic * fix * mutation * Add SF Mono, SF Pro Rounded Black * Add AnimatePresence * Update green/red colors * Add ConsoleSheet * Hook up iOS fonts * Hook up to PointsScreen * Style fixes * claim content * referral screen * referral ui * temp * fix android input and tabs * fix animation + back button android * layout fixes * final fixes + i18n * hook up some logic to claim signing * no retroactive points ui * fix points content layout * fix * animiation fix * referral code ui * fix invalid referral error * remove leaderboard row nav to profile * remove obsolete card + add rank card * black font weight for total points * refetch if past next distribution date * change rank icon to support higher ranks * leaderboard up to rank 100 * fix black font android * tweak sf mono font * dont render ens nft avatars in leaderboard * ActionButton * points icon animation * fix points gradient * format total # points users * restrict read only wallets * copy * referral code query update * fixing referral validation * fix merge error * fix referral code input * change metadata api fetch method from post to get * routes * i18n * console sheet nav --------- Co-authored-by: Christian Baroni <[email protected]> * add contentful points tweet intent schema and queries (#5228) * i18n * real referral url * rm TAB_BAR_HEIGHT * Add referral share step (#5229) * add contentful points tweet intent schema and queries * progress on points share screen * finish flow * clean up code and break it into smaller files * refactor progress * final changes * finished up * lint * revert graphql endpoint test * share bonus points --------- Co-authored-by: Ben Goldberg <[email protected]> * fix referral skeleton ui * fix android NeonButton * cleanup * types * add 3 dots back to calculating points * fix share link * fix android shadow clipping * fix continue button not showing * [APP-972]: Fix back button being under the bottom tab bar (#5231) * fix continue button not showing * fix back button being under the bottom tabbar * 1000 -> 100 bonus pts * add a hardcoded version of tweet intent to build copy (#5235) * fix placeholder on android (#5234) * add proper twitter intents * change intent slightly * fix: rainbow text spacing and font issues * fix fonts * Bug bash fixes (#5237) * additional onboard error handling * fix skip * copy * bump referral keyboard delay * fix double referral link when sharing * fix next drop card date conversion * tweak refetch interval slightly * twitter intent tweak * fix console animation + hide mm row if 0 * console button animation delay * tweak twitter intent * bonus points -> welcome bonus || true believer * block hardware wallet * leaderboard row onpress + refactor * next drop card tweak * deeplink * referral bug fix * fix android referral code text color * attempt to fix ledger sign on console sheet * analytics events * fix android points mask * add ledger (#5233) * add ledger * logs * logs * logs * analytics events * tweaks * logs * moar logs --------- Co-authored-by: Ben Goldberg <[email protected]> * remove url encoded (#5240) * added analytics events * next drop rounding fix * rm console logs --------- Co-authored-by: Christian Baroni <[email protected]> Co-authored-by: Matthew Wall <[email protected]> Co-authored-by: Derek <[email protected]> Co-authored-by: Skylar Barrera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
What changed (plus any additional context for devs)
Built out the following UI for points onboarding and hooked up the backend logic for referral code verification
Screen recordings / screenshots
What to test