-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Points: introductory flow #5201
Changes from 13 commits
e8389f7
5719397
719ca6e
7721a5f
7fbbb18
fad9f3e
ed30109
fdccb1f
499b705
cc4b78b
c09aea1
c5e1f8a
99a70ec
3fbbf9b
a036bea
b7efce0
b088b80
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ exports.config = { | |
metadata: { | ||
__name: 'metadata', | ||
document: './queries/metadata.graphql', | ||
schema: { method: 'GET', url: 'https://metadata.p.rainbow.me/v1/graph' }, | ||
schema: { method: 'POST', url: 'https://metadata.p.rainbow.me/v1/graph' }, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. afaik we should be using POST for all metadata calls, if you need to use POST feel free to rename the simulation config to something more generic and use that for points iirc POST messes with cloudflare caching so we should only use where necessary There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok cool thanks for the info. renamed simulation/simulationClient to metadataPOST/metadataPOSTClient |
||
}, | ||
simulation: { | ||
__name: 'simulation', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so keyboard doesn't push up tab bar on android
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should take a look at how this impacts the send flow