Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default loading favicon #131

Conversation

SeanM322
Copy link
Collaborator

I downloaded default loading favicon
and if you wanna set this svg as default you need to set:
In rair-front env file VITE_HTML_META_FAVICON_URI=./favicons/loading-favicon.svg
it's important!

@SeanM322 SeanM322 added backend (bug) Something isn't working frontend (bug) relates to rair-front system labels Jul 22, 2024
@SeanM322 SeanM322 self-assigned this Jul 22, 2024
@SeanM322 SeanM322 changed the base branch from main to dev July 22, 2024 12:32
@sarora180673
Copy link
Collaborator

Still not working perfectly. I have defined VITE_HTML_META_FAVICON_URI=./favicons/loading-favicon.svg
and also in settings uploaded a different favicon (hotdrops). If I navigate to different pages correct favicon is shown (hotdrops). But if I come to home page then default Rair favicon is shown.

Copy link
Collaborator

@sarora180673 sarora180673 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Verified

…settings-but-not-on-homepage-and-collections-etc
@sarora180673 sarora180673 merged commit f25b90c into dev Jul 23, 2024
@sarora180673 sarora180673 deleted the 102-inconsistent-favicon-rendering-on-server-settings-but-not-on-homepage-and-collections-etc branch July 23, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend (bug) Something isn't working frontend (bug) relates to rair-front system
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Inconsistent favicon rendering (on server settings but not on homepage and collections etc)
3 participants