Kubernetes: Support starting with no versions #7461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that the channels list response contains the expected `responseType`, so that if we got back invalid data we don't try to use it and end up clearing the cached list. Signed-off-by: Mark Yen <[email protected]>
We were accidentally sending the GitHub token to the non-GitHub host. This should be typically unset, but that's still kind of bad. Signed-off-by: Mark Yen <[email protected]>
If we had no internet access on first start and fail to download the list of k3s versions, force disable Kubernetes instead of failing. Signed-off-by: Mark Yen <[email protected]>
This was referenced Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we had no internet access on first start and fail to download the list of k3s versions, force disable Kubernetes instead of failing.
This also checks the k3s channel response harder, so that if we got a success code but some JSON that didn't include the correct contents, we'll reject it correctly.
Fixes #7412
On macOS, this is easier to test with
echo nameserver 0.0.0.0 | sudo tee /etc/resolver/update.k3s.iobefore factory resetting.