Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes: Support starting with no versions #7461

Merged
merged 3 commits into from
Sep 12, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
K3sHelper: Don't send GitHub token to k3s.io
We were accidentally sending the GitHub token to the non-GitHub host.
This should be typically unset, but that's still kind of bad.

Signed-off-by: Mark Yen <mark.yen@suse.com>
  • Loading branch information
mook-as committed Sep 11, 2024
commit f1b333523d8281841251c7752b713d942e24b80a
8 changes: 2 additions & 6 deletions pkg/rancher-desktop/backend/k3sHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -360,12 +360,8 @@ export default class K3sHelper extends events.EventEmitter {
let channelResponse: Response;

try {
const headers: HeadersInit = { Accept: this.channelApiAccept };

if (process.env.GITHUB_TOKEN) {
headers.Authorization = `Bearer ${ process.env.GITHUB_TOKEN }`;
}
channelResponse = await fetch(this.channelApiUrl, { headers });
channelResponse = await fetch(this.channelApiUrl,
{ headers: { Accept: this.channelApiAccept } });
} catch (ex: any) {
console.log(`updateCache: error: ${ ex }`);
if (!(await checkConnectivity('k3s.io'))) {
Expand Down