Add managedosversion finalizer #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmazzotti
force-pushed
the
add_managedosversion_finalizer
branch
from
fc5d8c5 to
c2f5826
Compare
anmazzotti
commented
Jun 21, 2024
| @@ -21,7 +21,7 @@ import ( | |||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | |||
| ) | |||
|
|
|||
| var ( | |||
| const ( | |||
There was a problem hiding this comment.
Very random change. Not related to this PR.
anmazzotti
commented
Jun 21, 2024
anmazzotti
force-pushed
the
add_managedosversion_finalizer
branch
from
49fe0be to
a1315c9
Compare
|
Also accidentally found how it looks like when the finalizer is preventing the deletion.
|
anmazzotti
force-pushed
the
add_managedosversion_finalizer
branch
from
a1315c9 to
b8bf5ff
Compare
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
anmazzotti
force-pushed
the
add_managedosversion_finalizer
branch
from
b8bf5ff to
d856ef2
Compare
fgiudici
approved these changes
Jun 25, 2024
Co-authored-by: Francesco Giudici <[email protected]> Signed-off-by: Andrea Mazzotti <[email protected]>
Co-authored-by: Francesco Giudici <[email protected]> Signed-off-by: Andrea Mazzotti <[email protected]>
Co-authored-by: Francesco Giudici <[email protected]> Signed-off-by: Andrea Mazzotti <[email protected]>
anmazzotti
added a commit
to anmazzotti/elemental-operator
that referenced
this pull request
Jun 26, 2024
* Implement ManagedOSVersion controller and finalizer Signed-off-by: Andrea Mazzotti <[email protected]> * Remove unused ManagedOSVersion Status Signed-off-by: Andrea Mazzotti <[email protected]> --------- Signed-off-by: Andrea Mazzotti <[email protected]> Co-authored-by: Francesco Giudici <[email protected]>
anmazzotti
added a commit
that referenced
this pull request
Jun 27, 2024
* Add managedosversion finalizer (#775) * Implement ManagedOSVersion controller and finalizer Signed-off-by: Andrea Mazzotti <[email protected]> * Remove unused ManagedOSVersion Status Signed-off-by: Andrea Mazzotti <[email protected]> * Block reinstall if crds are still pending to be deleted (#784) Signed-off-by: David Cassany <[email protected]> --------- Signed-off-by: Andrea Mazzotti <[email protected]> Signed-off-by: David Cassany <[email protected]>
davidcassany
added a commit
to rancher/elemental
that referenced
this pull request
Jun 27, 2024
Signed-off-by: David Cassany <[email protected]>
davidcassany
added a commit
to rancher/elemental
that referenced
this pull request
Jun 27, 2024
Signed-off-by: David Cassany <[email protected]>
davidcassany
added a commit
to rancher/elemental
that referenced
this pull request
Jun 27, 2024
Signed-off-by: David Cassany <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a pre-requisite to #759
A new controller has been added to manage the ManagedOSVersion finalizer.
This will prevent deletion of ManagedOSVersion that are still referenced by any ManagedOSImage.
To my knowledge there is no other direct reference to a ManagedOSVersion. The UI uses a cached list of versions when creating a new SeedImage, but this is presentation layer only, there's no reference to a ManagedOSVersion from a SeedImage.