[HOTFIX] Unpin numba<0.58 #15031
Merged
[HOTFIX] Unpin numba<0.58 #15031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
approved these changes
Feb 12, 2024
bdice
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Thanks. I'm terribly sorry, I knew this pinning could be a potential issue but it hadn't appeared in any error logs I had seen yet, so I hadn't prioritized it among other build/packaging fixes that were actively causing errors. I am planning to revisit several cudf pinnings (numpy, arrow, etc.) in 24.04 once I get a chance.
|
cc @brandon-b-miller (for awareness) |
|
Thanks all! 🙏 |
res-life
pushed a commit
to res-life/cudf
that referenced
this pull request
Feb 21, 2024
This reverts commit ac438c4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think unpinning
numbain the conda recipe was just missed in #14616.I discovered this issue trying to build the
24.02release.PRs & nightly builds are working because the
rapidsai-nightlychannel has an older version ofpynvjitlinkthat supportednumba>=0.57whereas therapidsaichannel only has the latest version which pins tonumba>=0.58.