Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kvikio call due to upstream changes #17733

Merged

Conversation

kingcrimsontianyu
Copy link
Contributor

@kingcrimsontianyu kingcrimsontianyu commented Jan 14, 2025

Description

KvikIO has just introduced slightly breaking code changes (rapidsai/kvikio#581) where the utility function getenv_or is moved out of the detail namespace and becomes part of the public API. This PR adapts cuDF for this change.

This PR has been tested locally using the abovementioned KvikIO branch.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@kingcrimsontianyu kingcrimsontianyu requested a review from a team as a code owner January 14, 2025 15:19
@kingcrimsontianyu kingcrimsontianyu self-assigned this Jan 14, 2025
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jan 14, 2025
@kingcrimsontianyu kingcrimsontianyu added non-breaking Non-breaking change libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function and removed libcudf Affects libcudf (C++/CUDA) code. labels Jan 14, 2025
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit fe75cb8 into rapidsai:branch-25.02 Jan 14, 2025
107 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants