Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and test with CUDA 12.8.0 #649

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 28, 2025

This PR uses CUDA 12.8.0 to build and test.

xref: rapidsai/build-planning#139

@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jan 28, 2025
Copy link

copy-pr-bot bot commented Jan 28, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added conda doc Documentation labels Jan 28, 2025
@bdice bdice added the DO NOT MERGE Hold off on merging; see PR for details label Jan 28, 2025
@bdice bdice marked this pull request as ready for review January 28, 2025 15:58
@bdice bdice requested review from a team as code owners January 28, 2025 15:58
@bdice bdice requested a review from gforsyth January 28, 2025 15:58
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test failed with what looks like a network error downloading some test data from GitHub.

cux_df = <cuxfilter.dataframe.DataFrame object at 0x7f46223787f0>

    @pytest.mark.parametrize("cux_df", cux_dfs)
    def test_init(self, cux_df):
>       choropleth3d_chart = charts.choropleth(
            x="states",
            color_column="val",
            elevation_column="val_t",
            color_aggregate_fn="mean",
            elevation_aggregate_fn="count",
            add_interaction=False,
            elevation_factor=100000,
            geoJSONSource=(
                "https://raw.githubusercontent.com/loganpowell/census-geojson"
                "/master/GeoJSON/5m/2018/state.json"
            ),
            geoJSONProperty="STATEFP",
            map_style="testMap",
        )

...
/opt/conda/envs/test/lib/python3.10/ssl.py:1375: ConnectionResetError

(build link)

I checked and the file really is there, so I guess this was just something temporary (https://github.com/rapidsai/cuxfilter/actions/runs/13014410941/job/36301473875?pr=649).

Restarted CI for you. I also opened #650 documenting the work to try to factor out that download.

Left one other suggestion about a few more updates that were missed in docs.

Approving, assuming those docs updates will be made. I don't need to re-review.

README.md Show resolved Hide resolved
@jameslamb jameslamb removed the request for review from gforsyth January 29, 2025 00:03
@vyasr vyasr removed DO NOT MERGE Hold off on merging; see PR for details doc Documentation labels Jan 29, 2025
@vyasr
Copy link
Contributor

vyasr commented Jan 29, 2025

/merge

@rapids-bot rapids-bot bot merged commit 6b2ed2d into rapidsai:branch-25.02 Jan 29, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants