Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rp2350/pad_checksum: fix set cpu #2335

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

AnnsAnns
Copy link

@AnnsAnns AnnsAnns commented Mar 6, 2025

See #2334

This PR should hopefully fix the incorrect cpu for the rp2350 in the pad_checksum function.

@@ -44,7 +44,7 @@ odata = idata + bytes(args.pad - len(idata))
with open(args.ofile, "w") as ofile:
ofile.write("// Padded and checksummed version of: {}\n\n".format(args.ifile))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this "and checksummed" file-comment is also misleading, as there's a code-comment a few lines above saying "No CRC..." ?
Also, looks like the --seed argument is entirely unused by the RP2350 version of this script? 🤔 (Ahhh, but perhaps it's needed for CLI-compatibility with the RP2040 version)

@AnnsAnns
Copy link
Author

After further investigation, it appears like this entire script is completely misleading, based on chapter 5.9.5 of the RP2350 documentation the boot2 checksum is not needed for the rp2350:

Unlike RP2040, there is no requirement for flash binaries to have a checksummed "boot2" flash setup function at flash address 0. The RP2350 bootrom performs a simple best-effort XIP setup during flash scanning, and a flash-resident program can continue executing in this state, or can choose to reconfigure the QSPI interface at a later time for best performance.

I am not really sure how to proceed with this PR, wouldn't it make sense to completely get rid of that script based on the fact that this isn't something the pico2 actually needs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants