Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rp2350/pad_checksum: fix set cpu #2335

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

rp2350/pad_checksum: fix set cpu #2335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/rp2350/boot_stage2/pad_checksum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ odata = idata + bytes(args.pad - len(idata))
with open(args.ofile, "w") as ofile:
ofile.write("// Padded and checksummed version of: {}\n\n".format(args.ifile))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this "and checksummed" file-comment is also misleading, as there's a code-comment a few lines above saying "No CRC..." ?
Also, looks like the --seed argument is entirely unused by the RP2350 version of this script? 🤔 (Ahhh, but perhaps it's needed for CLI-compatibility with the RP2040 version)

if args.arch == "arm":
ofile.write(".cpu cortex-m0plus\n")
ofile.write(".cpu cortex-m33\n")
ofile.write(".thumb\n\n")
ofile.write(".section .boot2, \"ax\"\n\n")
ofile.write(".global __boot2_entry_point\n")
Expand Down