Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.7.3 #1

Closed
wants to merge 31 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
cadaeb7
Non-tagged
AsparagusEduardo Jan 17, 2024
cae58ca
fixed oversight causing chosen fossil to be lost if bag is full (#3978)
fakuzatsu Jan 17, 2024
fd5d5cd
Fixed incorrect family toggle preproc blocks (#4024)
AsparagusEduardo Jan 19, 2024
f3342de
Condense Oinkologne teachable learnsets (#4026)
Bassoonian Jan 19, 2024
d125da7
Fixes Life Orb + Eject Pack / Red Card interaction (#4038)
AlexOn1ine Jan 20, 2024
73a1fa3
fix: emergency exit cutoff off by 1 on odd max hp (#4040)
SBird1337 Jan 21, 2024
53a46b7
Remove faulty teachable learnset moves (#4039)
Bassoonian Jan 21, 2024
04fa3aa
Fixes Emergency Exit when hp is restored over tag out range (#4041)
AlexOn1ine Jan 21, 2024
35e2157
Fixes ability Corrosion (#4037)
AlexOn1ine Jan 21, 2024
9286b80
Remove illegal moves from teachable learnsets (#4042)
Bassoonian Jan 21, 2024
a01d442
Fixed Kingra's learnset gen (#4044)
Skyeward Jan 21, 2024
0ec777d
Fixes Mind Blown / Magic Guard interaction and renames Steel Beam eff…
AlexOn1ine Jan 21, 2024
b99ec5d
Update level_up_learnsets.h (#4046)
Bassoonian Jan 21, 2024
91f429b
Fixes Glimmering Charm (#4047)
AlexOn1ine Jan 22, 2024
e995927
Add extra key item bag space checks (#4066)
Bassoonian Jan 26, 2024
3e50480
Fixed graphics bug with Steven double battle (#4078)
johannakullmann Jan 27, 2024
9bcd46b
Fixes Pursuit, Tangling Hair interaction (#4086)
AlexOn1ine Jan 28, 2024
127a7e9
Backported gHeap alignment fix from upstream pret
AsparagusEduardo Jan 28, 2024
2988883
Unused warnings are not treated as errrors by default
AsparagusEduardo Jan 29, 2024
e8a6c46
Only do unused error under RHH's repo + workflow test
AsparagusEduardo Jan 29, 2024
a0bcdbf
Workflow test worked, undoing changes
AsparagusEduardo Jan 29, 2024
a2a38a5
Added passing "KNOWN_FAILING" to test summary (#4063)
AsparagusEduardo Jan 29, 2024
8b62828
Fix HGSS Dex dark mode search palette (#4095)
ravepossum Jan 29, 2024
f562359
Fix AI trying to switch into the same mon 2 times (#4098)
DizzyEggg Jan 30, 2024
f7e5709
Review changes
AsparagusEduardo Jan 31, 2024
5af733a
Merge branch 'master' into _RHH/pr/master/unused
AsparagusEduardo Jan 31, 2024
1a65894
Fixes test description + small fix follow up (#4100)
AlexOn1ine Jan 31, 2024
e8538ef
Merge branch 'master' into _RHH/pr/master/unused
Bassoonian Feb 1, 2024
1d9e692
Unused warnings are no longer treated as errrors by default (#4092)
DizzyEggg Feb 1, 2024
2d24f96
Version 1.7.3 (#4106)
AsparagusEduardo Feb 1, 2024
58e4bec
1.7.3 Merge
kaicardenas2 Feb 2, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/ISSUE_TEMPLATE/01_battle_engine_bugs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@ body:
label: Version
description: What version of pokeemerald-expansion are you using as a base?
options:
- 1.7.2 (Latest release)
- 1.7.3 (Latest release)
- master (default when pulling, unreleased bugfixes)
- upcoming (Edge)
- 1.7.2
- 1.7.1
- 1.7.0
- 1.6.2
Expand Down
3 changes: 2 additions & 1 deletion .github/ISSUE_TEMPLATE/04_other_errors.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@ body:
label: Version
description: What version of pokeemerald-expansion are you using as a base?
options:
- 1.7.2 (Latest release)
- 1.7.3 (Latest release)
- master (default when pulling, unreleased bugfixes)
- upcoming (Edge)
- 1.7.2
- 1.7.1
- 1.7.0
- 1.6.2
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jobs:
GAME_LANGUAGE: ENGLISH
MODERN: 0
COMPARE: 0
UNUSED_ERROR: 1
steps:
- name: Checkout
uses: actions/checkout@v2
Expand Down
15 changes: 8 additions & 7 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
# Pokeemerald-Expansion Changelogs

## [Version 1.7.2](docs/changelogs/1.7.2.md) - Bugfix Release

## [Version 1.7.1](docs/changelogs/1.7.1.md) - Bugfix Release

## [Version 1.7.0](docs/changelogs/1.7.0.md) - Feature Release

## [Version 1.6.2](docs/changelogs/1.6.2.md) - Bugfix Release
## Version 1.7.x
### [Version 1.7.3](docs/changelogs/1.7.3.md) - Bugfix Release
### [Version 1.7.2](docs/changelogs/1.7.2.md) - Bugfix Release
### [Version 1.7.1](docs/changelogs/1.7.1.md) - Bugfix Release
### [Version 1.7.0](docs/changelogs/1.7.0.md) - Feature Release

## Version 1.6.x
### [Version 1.6.2](docs/changelogs/1.6.2.md) - Bugfix Release
21 changes: 14 additions & 7 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,14 @@ else
EXE :=
endif

TITLE := POKEMON EMER
GAME_CODE := BPEE
MAKER_CODE := 01
REVISION := 0
MODERN ?= 1
TEST ?= 0
ANALYZE ?= 0
TITLE := POKEMON EMER
GAME_CODE := BPEE
MAKER_CODE := 01
REVISION := 0
MODERN ?= 1
TEST ?= 0
ANALYZE ?= 0
UNUSED_ERROR ?= 0

ifeq (agbcc,$(MAKECMDGOALS))
MODERN := 0
Expand Down Expand Up @@ -127,6 +128,12 @@ override CFLAGS += -mthumb -mthumb-interwork -O2 -mabi=apcs-gnu -mtune=arm7tdmi
ifeq ($(ANALYZE),1)
override CFLAGS += -fanalyzer
endif
# Only throw an error for unused elements if its RH-Hideout's repo
ifeq ($(UNUSED_ERROR),0)
ifneq ($(GITHUB_REPOSITORY_OWNER),rh-hideout)
override CFLAGS += -Wno-error=unused-variable -Wno-error=unused-const-variable -Wno-error=unused-parameter -Wno-error=unused-function -Wno-error=unused-but-set-parameter -Wno-error=unused-but-set-variable -Wno-error=unused-value -Wno-error=unused-local-typedefs
endif
endif
ROM := $(MODERN_ROM_NAME)
OBJ_DIR := $(MODERN_OBJ_DIR_NAME)
LIBPATH := -L "$(dir $(shell $(PATH_MODERNCC) -mthumb -print-file-name=libgcc.a))" -L "$(dir $(shell $(PATH_MODERNCC) -mthumb -print-file-name=libnosys.a))" -L "$(dir $(shell $(PATH_MODERNCC) -mthumb -print-file-name=libc.a))"
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ pokeemerald-expansion is a decomp hack base project based off pret's [pokeemeral
If you use pokeemerald-expansion in your hack, please add RHH (Rom Hacking Hideout) to your credits list. Optionally, you can list the version used, so it can help players know what features to expect.
You can phrase it as the following:
```
Based off RHH's pokeemerald-expansion v1.7.2 https://github.com/rh-hideout/pokeemerald-expansion/
Based off RHH's pokeemerald-expansion v1.7.3 https://github.com/rh-hideout/pokeemerald-expansion/
```

## What features are included?
Expand Down Expand Up @@ -166,7 +166,7 @@ With this, you'll get the latest version of pokeemerald-expansion, plus a couple

## **How do I update my version of pokeemerald-expansion?**
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.7.2`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.7.3`.

### Please consider crediting the entire [list of contributors](https://github.com/rh-hideout/pokeemerald-expansion/wiki/Credits) in your project, as they have all worked hard to develop this project :)

Expand Down
7 changes: 5 additions & 2 deletions data/battle_scripts_1.s
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ gBattleScriptsForMoveEffects::
.4byte BattleScript_EffectHit @ EFFECT_RISING_VOLTAGE
.4byte BattleScript_EffectHit @ EFFECT_BEAK_BLAST
.4byte BattleScript_EffectCourtChange @ EFFECT_COURT_CHANGE
.4byte BattleScript_EffectSteelBeam @ EFFECT_STEEL_BEAM
.4byte BattleScript_EffectMaxHp50Recoil @ EFFECT_MAX_HP_50_RECOIL
.4byte BattleScript_EffectExtremeEvoboost @ EFFECT_EXTREME_EVOBOOST
.4byte BattleScript_EffectHitSetRemoveTerrain @ EFFECT_HIT_SET_REMOVE_TERRAIN
.4byte BattleScript_EffectDarkVoid @ EFFECT_DARK_VOID
Expand Down Expand Up @@ -927,7 +927,7 @@ BattleScript_EffectShellTrap::
waitmessage B_WAIT_TIME_LONG
goto BattleScript_MoveEnd

BattleScript_EffectSteelBeam::
BattleScript_EffectMaxHp50Recoil::
attackcanceler
attackstring
ppreduce
Expand Down Expand Up @@ -3592,6 +3592,7 @@ BattleScript_MindBlownDamp:
goto BattleScript_DampStopsExplosion
BattleScript_EffectMindBlown_HpDown:
setbyte sMULTIHIT_EFFECT, 1 @ Note to not faint the attacker
jumpifability BS_ATTACKER, ABILITY_MAGIC_GUARD, BattleScript_EffectMindBlown_AnimDmgNoFaint
dmg_1_2_attackerhp
healthbarupdate BS_ATTACKER
datahpupdate BS_ATTACKER
Expand Down Expand Up @@ -6715,6 +6716,7 @@ BattleScript_PrintFullBox::

BattleScript_ActionSwitch::
hpthresholds2 BS_ATTACKER
copybyte sSAVED_BATTLER, gBattlerAttacker
printstring STRINGID_RETURNMON
jumpifbattletype BATTLE_TYPE_DOUBLE, BattleScript_PursuitSwitchDmgSetMultihit
setmultihit 1
Expand All @@ -6732,6 +6734,7 @@ BattleScript_DoSwitchOut::
switchoutabilities BS_ATTACKER
updatedynamax
waitstate
copybyte gBattlerAttacker, sSAVED_BATTLER
returnatktoball
waitstate
drawpartystatussummary BS_ATTACKER
Expand Down
2 changes: 2 additions & 0 deletions data/maps/DesertUnderpass/scripts.inc
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,14 @@ DesertUnderpass_EventScript_Fossil::

DesertUnderpass_EventScript_GiveClawFossil::
giveitem ITEM_CLAW_FOSSIL
goto_if_eq VAR_RESULT, FALSE, Common_EventScript_ShowBagIsFull
removeobject LOCALID_FOSSIL
release
end

DesertUnderpass_EventScript_GiveRootFossil::
giveitem ITEM_ROOT_FOSSIL
goto_if_eq VAR_RESULT, FALSE, Common_EventScript_ShowBagIsFull
removeobject LOCALID_FOSSIL
release
end
Expand Down
1 change: 1 addition & 0 deletions data/maps/MauvilleCity/scripts.inc
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,7 @@ MauvilleCity_EventScript_Wattson::
goto_if_set FLAG_GOT_BASEMENT_KEY_FROM_WATTSON, MauvilleCity_EventScript_BegunNewMauville
msgbox MauvilleCity_Text_WattsonNeedFavorTakeKey, MSGBOX_DEFAULT
giveitem ITEM_BASEMENT_KEY
goto_if_eq VAR_RESULT, FALSE, Common_EventScript_ShowBagIsFull
setflag FLAG_GOT_BASEMENT_KEY_FROM_WATTSON
msgbox MauvilleCity_Text_WattsonWontBeChallenge, MSGBOX_DEFAULT
release
Expand Down
2 changes: 2 additions & 0 deletions data/maps/MauvilleCity_BikeShop/scripts.inc
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,14 @@ MauvilleCity_BikeShop_EventScript_YesFar::
MauvilleCity_BikeShop_EventScript_GetMachBike::
msgbox MauvilleCity_BikeShop_Text_ChoseMachBike, MSGBOX_DEFAULT
giveitem ITEM_MACH_BIKE
goto_if_eq VAR_RESULT, FALSE, Common_EventScript_ShowBagIsFull
goto MauvilleCity_BikeShop_EventScript_ComeBackToSwitchBikes
end

MauvilleCity_BikeShop_EventScript_GetAcroBike::
msgbox MauvilleCity_BikeShop_Text_ChoseAcroBike, MSGBOX_DEFAULT
giveitem ITEM_ACRO_BIKE
goto_if_eq VAR_RESULT, FALSE, Common_EventScript_ShowBagIsFull
goto MauvilleCity_BikeShop_EventScript_ComeBackToSwitchBikes
end

Expand Down
3 changes: 2 additions & 1 deletion data/maps/MauvilleCity_House2/scripts.inc
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@ MauvilleCity_House2_EventScript_AskToTradeForHarborMail::

MauvilleCity_House2_EventScript_AcceptTrade::
msgbox MauvilleCity_House2_Text_IllTradeYouCoinCase, MSGBOX_DEFAULT
removeitem ITEM_HARBOR_MAIL
giveitem ITEM_COIN_CASE
goto_if_eq VAR_RESULT, FALSE, Common_EventScript_ShowBagIsFull
removeitem ITEM_HARBOR_MAIL
setflag FLAG_RECEIVED_COIN_CASE
goto MauvilleCity_House2_EventScript_ReceivedCoinCase
end
Expand Down
2 changes: 2 additions & 0 deletions data/maps/MirageTower_4F/scripts.inc
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ MirageTower_4F_EventScript_RootFossil::
msgbox MirageTower_4F_Text_TakeRootFossil, MSGBOX_YESNO
goto_if_eq VAR_RESULT, NO, MirageTower_4F_EventScript_LeaveRootFossil
giveitem ITEM_ROOT_FOSSIL
goto_if_eq VAR_RESULT, FALSE, Common_EventScript_ShowBagIsFull
closemessage
setflag FLAG_HIDE_MIRAGE_TOWER_ROOT_FOSSIL
setflag FLAG_HIDE_MIRAGE_TOWER_CLAW_FOSSIL
Expand All @@ -30,6 +31,7 @@ MirageTower_4F_EventScript_ClawFossil::
msgbox MirageTower_4F_Text_TakeClawFossil, MSGBOX_YESNO
goto_if_eq VAR_RESULT, NO, MirageTower_4F_EventScript_LeaveClawFossil
giveitem ITEM_CLAW_FOSSIL
goto_if_eq VAR_RESULT, FALSE, Common_EventScript_ShowBagIsFull
closemessage
setflag FLAG_HIDE_MIRAGE_TOWER_CLAW_FOSSIL
setflag FLAG_HIDE_MIRAGE_TOWER_ROOT_FOSSIL
Expand Down
1 change: 1 addition & 0 deletions data/maps/MossdeepCity_House3/scripts.inc
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ MossdeepCity_House3_EventScript_SuperRodFisherman::
goto_if_eq VAR_RESULT, NO, MossdeepCity_House3_EventScript_DeclineSuperRod
msgbox MossdeepCity_House3_Text_SuperRodIsSuper, MSGBOX_DEFAULT
giveitem ITEM_SUPER_ROD
goto_if_eq VAR_RESULT, FALSE, Common_EventScript_ShowBagIsFull
setflag FLAG_RECEIVED_SUPER_ROD
msgbox MossdeepCity_House3_Text_TryDroppingRodInWater, MSGBOX_DEFAULT
release
Expand Down
1 change: 1 addition & 0 deletions data/maps/MtChimney/scripts.inc
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,7 @@ MtChimney_EventScript_MeteoriteMachine::
goto_if_eq VAR_RESULT, NO, MtChimney_EventScript_LeaveMeteoriteAlone
msgbox MtChimney_Text_PlayerRemovedMeteorite, MSGBOX_DEFAULT
giveitem ITEM_METEORITE
goto_if_eq VAR_RESULT, FALSE, Common_EventScript_ShowBagIsFull
setflag FLAG_RECEIVED_METEORITE
releaseall
end
Expand Down
1 change: 1 addition & 0 deletions data/maps/Route104_PrettyPetalFlowerShop/scripts.inc
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ Route104_PrettyPetalFlowerShop_EventScript_WailmerPailGirl::
Route104_PrettyPetalFlowerShop_EventScript_GiveWailmerPail::
msgbox Route104_PrettyPetalFlowerShop_Text_YouCanHaveThis, MSGBOX_DEFAULT
giveitem ITEM_WAILMER_PAIL
goto_if_eq VAR_RESULT, FALSE, Common_EventScript_ShowBagIsFull
msgbox Route104_PrettyPetalFlowerShop_Text_WailmerPailExplanation, MSGBOX_DEFAULT
setflag FLAG_RECEIVED_WAILMER_PAIL
release
Expand Down
1 change: 1 addition & 0 deletions data/maps/Route113_GlassWorkshop/scripts.inc
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ Route113_GlassWorkshop_EventScript_GlassWorker::
goto_if_eq VAR_GLASS_WORKSHOP_STATE, 1, Route113_GlassWorkshop_EventScript_ExplainSootSack
msgbox Route113_GlassWorkshop_Text_GoCollectAshWithThis, MSGBOX_DEFAULT
giveitem ITEM_SOOT_SACK
goto_if_eq VAR_RESULT, FALSE, Common_EventScript_ShowBagIsFull
setvar VAR_GLASS_WORKSHOP_STATE, 1
msgbox Route113_GlassWorkshop_Text_ExplainSootSack, MSGBOX_DEFAULT
release
Expand Down
1 change: 1 addition & 0 deletions data/maps/Route118/scripts.inc
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ Route118_EventScript_GoodRodFisherman::
Route118_EventScript_ReceiveGoodRod::
msgbox Route118_Text_IdenticalMindsTakeThis, MSGBOX_DEFAULT
giveitem ITEM_GOOD_ROD
goto_if_eq VAR_RESULT, FALSE, Common_EventScript_ShowBagIsFull
setflag FLAG_RECEIVED_GOOD_ROD
msgbox Route118_Text_TryYourLuckFishing, MSGBOX_DEFAULT
release
Expand Down
1 change: 1 addition & 0 deletions data/scripts/contest_hall.inc
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ LilycoveCity_ContestLobby_EventScript_ReceptionWelcome::
LilycoveCity_ContestLobby_EventScript_GivePokeblockCase::
msgbox LilycoveCity_ContestLobby_Text_ReceptionDontHavePokeblockCase, MSGBOX_DEFAULT
giveitem ITEM_POKEBLOCK_CASE
goto_if_eq VAR_RESULT, FALSE, Common_EventScript_ShowBagIsFull
setflag FLAG_RECEIVED_POKEBLOCK_CASE
msgbox LilycoveCity_ContestLobby_Text_NowThatWeveClearedThatUp, MSGBOX_DEFAULT
return
Expand Down
2 changes: 1 addition & 1 deletion docs/changelogs/1.7.2.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Template
# Version 1.7.2

```md
## How to update
Expand Down
77 changes: 77 additions & 0 deletions docs/changelogs/1.7.3.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
# Version 1.7.3

```md
## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.7.3`.
```

## 🌋 *IMPORTANT CHANGES* 🌋
* Unused warnings are no longer treated as errrors by default by @AsparagusEduardo in https://github.com/rh-hideout/pokeemerald-expansion/pull/4092
* [Critical fix] Backported gHeap alignment fix from upstream pret by @AsparagusEduardo in https://github.com/rh-hideout/pokeemerald-expansion/pull/4089
* Fixes issue that causes graphics to bug when leaving Littleroot for Birch's cutscene.

## 🧬 General 🧬
* Fixed HGSS Dex's dark mode search palette by @ravepossum in https://github.com/rh-hideout/pokeemerald-expansion/pull/4095

## 🐉 Pokémon 🐉
### Changed
* Condensed Oinkologne teachable learnsets (they previously had different tables despite having the same learnsets) by @Bassoonian in https://github.com/rh-hideout/pokeemerald-expansion/pull/4026
* Removed illegal teachable learnset moves that didn't match Gen 7 or 9 by @Bassoonian in https://github.com/rh-hideout/pokeemerald-expansion/pull/4039 and https://github.com/rh-hideout/pokeemerald-expansion/pull/4042
### Fixed
* Fixed incorrect family toggle preproc blocks by @AsparagusEduardo in https://github.com/rh-hideout/pokeemerald-expansion/pull/4024
* Cosplay and Cap Pikachu animations were still being included even if disabled.
* Fixed compile errors when:
* Feebas' family was disabled but not Castform.
* Chatot was disabled but not Spiritomb.
* Virizion was disabled but not Tornadus or Thundurus.
* Zekrom was disabled but not Landorus.
* Kyurem was disabled but not Keldeo or Meloetta.
* Wishiwashi was disabled but not Rockruff.
* Fixed compile error when disabling Gen 4 cross-evolutions while having Kingdra enabled by @Skyeward and @Bassoonian in https://github.com/rh-hideout/pokeemerald-expansion/pull/4044 and https://github.com/rh-hideout/pokeemerald-expansion/pull/4046

## ⚔️ Battle General ⚔️ ##
### Fixed
* Fixed Steven double battle palette error by @johannakullmann in https://github.com/rh-hideout/pokeemerald-expansion/pull/4078

## 🤹 Moves 🤹
### Changed
* Renamed `EFFECT_STEEL_BEAM` to `EFFECT_MAX_HP_50_RECOIL` by @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4043
### Fixed
* Fixed Pursuit's effect not working by @ZnogyroP @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4086

## 🎭 Abilities 🎭
### Fixed
* Fixed Emergency Exit issues:
* Fixed rounding error that caused it to not switch out when odd-numbered HP was off by 1 by @SBird1337 in https://github.com/rh-hideout/pokeemerald-expansion/pull/4040
* Eg: going from 101 Max HP to 50 HP would've *not* cause it to switch out.
* Fixes Emergency Exit switching out even if the Pokémon was healed above the threshold before it would've triggered by @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4041
* Eg: going from 100 Max HP to 45 HP and eating a Sitrus Berry back to 55 HP would've cause it to switch out.
* Cleanup by @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4100
* Fixed Corrosion only working for status moves by @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4037
* Fixed Magic Guard not preventing Mind Blown recoil damage by @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4043

## 🧶 Items 🧶
### Fixed
* Fixed oversight causing chosen fossil to be lost if bag is full by @fakuzatsu in https://github.com/rh-hideout/pokeemerald-expansion/pull/3978
* Fixed other Key Item script oversights by @Bassoonian in https://github.com/rh-hideout/pokeemerald-expansion/pull/4066
* Fixed Life Orb causing damage on switch-in from Eject Pack and Red Card by @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4038
* Fixed Glimmering Charm sprite by @SonikkuA-DatH and @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4047

## 🤖 Battle AI 🤖
### Fixed
* Fixed AI trying to switch into the same mon twice in the same turn by @DizzyEggg in https://github.com/rh-hideout/pokeemerald-expansion/pull/4098

## 🧪 Test Runner 🧪
### Added
* Corrosion tests by @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4037
* Pursuit/Tangling Hair interaction by @ZnogyroP @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4086
### Changed
* Passing `KNOWN_FAILING` tests are now listed separately from `PASSED` tests by @AsparagusEduardo in https://github.com/rh-hideout/pokeemerald-expansion/pull/4063

## New Contributors
* @Skyeward made their first contribution in https://github.com/rh-hideout/pokeemerald-expansion/pull/4044

**Full Changelog**: https://github.com/rh-hideout/pokeemerald-expansion/compare/expansion/1.7.2...expansion/1.7.3

<!--Last PR: 4098-->
6 changes: 3 additions & 3 deletions docs/changelogs/template.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
```md
## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.7.2`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.Y.Z`.
```

## 🌋 *IMPORTANT CHANGES* 🌋
Expand Down Expand Up @@ -88,6 +88,6 @@
## New Contributors
* Tony

**Full Changelog**: https://github.com/rh-hideout/pokeemerald-expansion/compare/expansion/1.7.1...expansion/1.7.2
**Full Changelog**: https://github.com/rh-hideout/pokeemerald-expansion/compare/expansion/1.Y.Z...expansion/1.Y.Z

<!--Last PR: 3697-->
<!--Last PR: ____-->
23 changes: 12 additions & 11 deletions graphics/items/icon_palettes/glimmering_charm.pal
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
JASC-PAL
0100
15
114 109 97
16
0 0 0
115 62 231
49 49 49
60 195 171
57 95 90
52 103 15
255 255 255
255 204 227
202 150 255
115 62 231
48 101 216
225 59 159
136 154 143
60 195 171
219 48 105
76 204 74
202 150 255
52 103 15
136 154 143
142 191 235
242 193 215
238 219 161
255 255 255
255 211 201
255 235 173
Binary file modified graphics/items/icons/glimmering_charm.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading