Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New simulate and power analysis interfaces #282

Merged
merged 18 commits into from
Jul 10, 2024
Merged

New simulate and power analysis interfaces #282

merged 18 commits into from
Jul 10, 2024

Conversation

kenkellner
Copy link
Collaborator

Overhauls the simulate and powerAnalysis functions so they are (hopefully) more intuitive and easier to use. Fixes #280.

The basic workflow is

  1. Create the appropriate type of unmarkedFrame with all the necessary design info and a blank y-matrix
  2. Provide this to simulate/powerAnalysis along with any arguments needed for model fitting, such as formulas
  3. That's all

Significantly reduces the code complexity and also makes more sense than what I was doing previously, I think.

At the moment I have kept the old interfaces intact for backwards compatibility, but marked them as deprecated. I'm not sure if I will eventually remove them.

@kenkellner kenkellner merged commit f3b0e45 into master Jul 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify simulate method
1 participant