Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Django 5.x in setup.py #240

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

calebsyring
Copy link
Contributor

Refs #238

Once this is released, #238 should be closed.

@calebsyring
Copy link
Contributor Author

calebsyring commented Mar 27, 2024

I'm not sure where these checks are configured 👇, but assuming the second number in parentheses is the django version, we may want to add a 5.0 check.

@jheld
Copy link
Collaborator

jheld commented Mar 27, 2024

Oh yes good call. They are in:

django-version: [4.0, 4.1, 4.2]

@calebsyring calebsyring force-pushed the 238-django-5.x branch 3 times, most recently from c6ca62b to 16c8972 Compare March 27, 2024 14:36
@calebsyring
Copy link
Contributor Author

Okay. Took some trial-and-error, but I updated the build file. Also updated the readme while I was at it. Should be GTG.

@calebsyring
Copy link
Contributor Author

Actually, hold off.

@calebsyring
Copy link
Contributor Author

Actually, hold off.

I wanted to update setup.py to change the django version requirement based on the python version. That's done now.

@jheld jheld merged commit cfc8a76 into rdegges:develop Mar 27, 2024
15 checks passed
@jheld
Copy link
Collaborator

jheld commented Mar 27, 2024

OK, the alpha version is now on PyPI. Once you've tested this in some reasonably confident way, let me know and I'll cut the official release!

@aaronmader
Copy link

0.14.3.4a1 appears to be working well, for my projects, though I'm currently only making use of:
from django_twilio.decorators import twilio_view, and
from django_twilio.client import twilio_client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants