Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Ruby SDK Improvements #350

Merged
merged 14 commits into from
Jan 6, 2022
Merged

feat: Ruby SDK Improvements #350

merged 14 commits into from
Jan 6, 2022

Conversation

ilias-t
Copy link
Contributor

@ilias-t ilias-t commented Jan 4, 2022 •
edited
Loading

🧰 What's being changed?

@ilias-t ilias-t requested a review from Dashron January 4, 2022 23:17
@erunion erunion added area:ruby enhancement New feature or request labels Jan 4, 2022
@ilias-t ilias-t requested a review from erunion January 4, 2022 23:40
erunion
erunion reviewed Jan 4, 2022
View reviewed changes
packages/ruby/README.md Show resolved Hide resolved
packages/ruby/README.md Show resolved Hide resolved
packages/ruby/lib/readme/har/serializer.rb Show resolved Hide resolved
packages/ruby/lib/readme/payload.rb Show resolved Hide resolved
erunion
erunion approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have zero Ruby experience but these changes make sense and tests are all green

@Dashron
Copy link
Contributor

Dashron commented Jan 5, 2022

looks great (I also don't know ruby), I'll approve once the group function change is in.

kellyjosephprice
kellyjosephprice approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@kellyjosephprice kellyjosephprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ilias-t ilias-t merged commit 50267ff into main Jan 6, 2022
@ilias-t ilias-t deleted the rm-2964 branch January 6, 2022 20:44
@erunion erunion added the ruby Issues related to our Ruby SDK label Jul 26, 2024
@erunion erunion removed the area:ruby label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellyjosephprice kellyjosephprice kellyjosephprice approved these changes

@erunion erunion erunion approved these changes

@Dashron Dashron Awaiting requested review from Dashron

Assignees
No one assigned
Labels
enhancement New feature or request ruby Issues related to our Ruby SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilias-t @Dashron @erunion @kellyjosephprice