Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the "clang-format" provided by the system #7554

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Use the "clang-format" provided by the system #7554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02037b6
Use the "clang-format" provided by the system
kraenhansen Apr 4, 2024
39378b3
Adding a note to the changelog
kraenhansen Apr 4, 2024
ca8eb0c
Merge branch 'master' into kh/bindgen/system-clang-format
kraenhansen Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
* Recreating the sync metadata Realm when the encryption key changes is now done in a multi-process safe manner ([PR #7526](https://github.com/realm/realm-core/pull/7526)).
* Added `App::default_base_url()` static accessor for SDKs to retrieve the default base URL from Core. ([PR #7534](https://github.com/realm/realm-core/pull/7534))
* Realm2JSON tool will now correctly upgrade file to current fileformat.
* (bindgen) Remove dependency on the `clang-format` package and rely on a binary provided by the system instead.

----------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion bindgen/src/formatter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,4 @@ export function format(formatter: Formatter, cwd: string, filePaths: string[]):
}
}

export const clangFormat = createCommandFormatter("clang", ["npx", "clang-format", "-i"]);
export const clangFormat = createCommandFormatter("clang", ["clang-format", "-i"]);
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"chalk": "^4.1.2",
"change-case": "^4.1.2",
"chevrotain": "^10.4.0",
"clang-format": "^1.8.0",
"commander": "^11.1.0",
"debug": "^4.3.4",
"typescript-json-schema": "^0.55.0",
Expand Down
Loading