Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the "clang-format" provided by the system #7554

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

kraenhansen
Copy link
Member

What, How & Why?

The clang-format package is unmaintained angular/clang-format#82 (comment) and it doesn't publish arm64 based binaries. I suggest we remove the dependency and rely on the binary provided by the system instead.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@kraenhansen kraenhansen self-assigned this Apr 4, 2024
@cla-bot cla-bot bot added the cla: yes label Apr 4, 2024
@kraenhansen kraenhansen requested a review from elle-j April 4, 2024 20:03
Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kraenhansen
Copy link
Member Author

Merging as bindgen unit tests are passing and they're the only tests that could be affected by this change.

@kraenhansen kraenhansen merged commit 2e9cee0 into master Apr 4, 2024
30 of 35 checks passed
@kraenhansen kraenhansen deleted the kh/bindgen/system-clang-format branch April 4, 2024 21:50
Copy link

Pull Request Test Coverage Report for Build kraen.hansen_58

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 39 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.002%) to 91.882%

Files with Coverage Reduction New Missed Lines %
src/realm/object-store/sync/sync_session.cpp 2 93.48%
src/realm/uuid.cpp 2 97.01%
src/realm/sync/network/network.hpp 3 85.17%
test/test_thread.cpp 3 66.67%
test/fuzz_group.cpp 4 53.45%
src/realm/sync/network/default_socket.cpp 5 73.35%
src/realm/sync/network/network_ssl.hpp 8 85.82%
src/realm/sync/noinst/server/server.cpp 12 77.09%
Totals Coverage Status
Change from base Build 2193: -0.002%
Covered Lines: 243951
Relevant Lines: 265506

💛 - Coveralls

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants