Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RJS-2870: Remove an unused header from the iOS and unused import from Android binding #6812

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

kraenhansen
Copy link
Member

What, How & Why?

This closes #6808 by removing an import which is no longer used.
The fix was verified by the original creator of the issue here: #6808 (comment)

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests (by the original reporter)
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary
  • 🔔 Mention @realm/devdocs if documentation changes are needed

@kraenhansen kraenhansen self-assigned this Jul 24, 2024
@kraenhansen kraenhansen requested a review from gagik July 24, 2024 15:33
@cla-bot cla-bot bot added the cla: yes label Jul 24, 2024
@sunrise1002
Copy link

So in this file
node_modules/realm/binding/android/src/main/java/io/realm/react/RealmReactModule.java
we also have to remove this line for android 🤔
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags;

@kraenhansen kraenhansen force-pushed the kh/removed-unused-react-native-ios-header branch from 9f032ca to 1309728 Compare July 25, 2024 11:07
@kraenhansen kraenhansen changed the title Remove an unused header from the React Native iOS binding Remove an unused header from the iOS and unused import from Android binding Jul 25, 2024
@kraenhansen kraenhansen requested a review from gagik July 25, 2024 11:08
@kraenhansen kraenhansen changed the title Remove an unused header from the iOS and unused import from Android binding RJS-2870: Remove an unused header from the iOS and unused import from Android binding Jul 25, 2024
@kraenhansen kraenhansen merged commit a431b86 into main Jul 25, 2024
32 of 34 checks passed
@kraenhansen kraenhansen deleted the kh/removed-unused-react-native-ios-header branch July 25, 2024 20:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Realm does not build on iOS with use_frameworks! :linkage => :static as of version 12.12.0
3 participants