Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RJS-2870: Remove an unused header from the iOS and unused import from Android binding #6812

Merged
merged 3 commits into from
Jul 25, 2024
Merged

RJS-2870: Remove an unused header from the iOS and unused import from Android binding #6812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88e62c6
Update RealmReactModule.mm to avoid including an unused header
kraenhansen Jul 24, 2024
bf9ad85
Update RealmReactModule.java to avoid importing an unused class
kraenhansen Jul 25, 2024
1309728
Adding a note to the changelog
kraenhansen Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,15 @@
* None

### Fixed
* <How to hit and notice issue? what was the impact?> ([#????](https://github.com/realm/realm-js/issues/????), since v?.?.?)
* None
* Fixed compiler error when building binding for React Native iOS: "'React-featureflags/react/featureflags/ReactNativeFeatureFlags.h' file not found" ([#6808](https://github.com/realm/realm-js/issues/6808), since v12.12.0)

### Compatibility
* React Native >= v0.71.4
* Realm Studio v15.0.0.
* File format: generates Realms with format v24 (reads and upgrades file format v10).

### Internal
<!-- * Either mention core version or upgrade -->
<!-- * Using Realm Core vX.Y.Z -->
<!-- * Upgraded Realm Core from vX.Y.Z to vA.B.C -->
* Removed an unused import in the binding for React Native Android. ([#6808](https://github.com/realm/realm-js/issues/6808), since v12.12.0)

## 12.12.0 (2024-07-23)

Expand Down
1 change: 0 additions & 1 deletion packages/realm/binding/android/src/main/java/io/realm/react/RealmReactModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.bridge.ReactContextBaseJavaModule;
import com.facebook.react.bridge.ReactMethod;
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags;
import com.facebook.react.module.annotations.ReactModule;
import com.facebook.react.turbomodule.core.interfaces.CallInvokerHolder;
import com.facebook.soloader.SoLoader;
Expand Down
1 change: 0 additions & 1 deletion packages/realm/binding/apple/RealmReactModule.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
#import <React/RCTBridge+Private.h>
#import <React/RCTInvalidating.h>
#import <ReactCommon/CallInvoker.h>
#import <React-featureflags/react/featureflags/ReactNativeFeatureFlags.h>
#import <jsi/jsi.h>

#import <arpa/inet.h>
Expand Down
Loading