Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if the password a user entered against the password in the… #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check if the password a user entered against the password in the… #127

wants to merge 1 commit into from

Conversation

eransevil
Copy link

… DB for the same user

Issue #103

@lmilbaum lmilbaum self-requested a review January 6, 2020 07:44
lmilbaum
lmilbaum suggested changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@lmilbaum lmilbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR should NOT be submitted from the master branch.
Please verify why CI did not run on this PR.

@Omeramsc
Copy link
Contributor

Omeramsc commented Jan 8, 2020

@eransevil The password in the DB is hashed, you can't authenticate it with normal string comparison.

@eransevil eransevil mentioned this pull request Jan 19, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmilbaum lmilbaum lmilbaum requested changes

At least 1 approving review is required to merge this pull request.

Assignees

@eransevil eransevil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eransevil @Omeramsc @lmilbaum