Add label checking for group reviews #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frival
previously approved these changes
Jan 20, 2025
kdvalin
added
pr_inprogress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a workflow to prevent merging without a label being applied indicating the PR has gone through a group code review.
Before/After Comparison
Before this PR, there is nothing preventing anyone from merging a PR without going through a group code review.
After this PR, the PR will need an additional label (currently
group_review_lgtm) before a merge can happen. This will allow others to submit approving code reviews before a group code review meeting and still prevent merging until the label has been applied to the PR.There is no Issue number or Jira ticket associated with this PR.