Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label checking for group reviews #153

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Add label checking for group reviews #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64cf1b4
Feat: Add ability to check for a label marking a group review approval
kdvalin Jan 17, 2025
b1e4a67
Merge branch 'main' of https://github.com/redhat-performance/zathras …
kdvalin Jan 21, 2025
74efdeb
Docs(ci): Add documentation about group review label
kdvalin Jan 21, 2025
a49b2df
Docs(ci): Add example of GitHub CLI adding a label to a pr
kdvalin Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/check_review_label.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: Verify group review

on:
pull_request:
types:
- opened
- labeled

env:
TARGET_LABEL: 'group_review_lgtm'

jobs:
check_review_label:
runs-on: ubuntu-latest
steps:
- run: echo "::error Missing review label" && exit 1
if: "!contains(github.event.pull_request.labels.*.name, env.TARGET_LABEL)"

- run: echo "Has review label"

7 changes: 7 additions & 0 deletions ci/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Workflows in this repository

## Verify group review
This workflow requires PRs to have an additional label before they can be merged into the main branch. Currently the label is `group_review_lgtm`, which is intended to be issued once the PR has been through a group review.

This can be done via the GitHub CLI by using the command
`gh pr edit <PR NUMBER> --add-label group_review_lgtm`.


## Verify PR has JIRA ticket and issue number
This workflow is designed to enforce requirements for PR descriptions. At bare minimum it requires the PR to mention a related issue and mention the Jira Ticket number. Both of these are required since Sync2Jira does not know how to associate a PR with a Jira Ticket from the originating GitHub issue.

Expand Down
Loading