Disallow binary dependencies in python packages #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachi2 will set the `cachi2:pip:package:binary` property to `true` for the dependencies from pip that contain binaries within them. This in conjunction with [PR#1030][1] will not allow those. Reference: https://issues.redhat.com/browse/EC-638 [1] enterprise-contract/ec-policies#1030
|
enterprise-contract/ec-policies#1030 is merged, though this should be okay to merge regardless. @rhartman93 can you have a look? |
simonbaird
reviewed
Jun 20, 2024
| @@ -161,6 +161,10 @@ rule_data: | |||
| # https://github.com/hashicorp/vault-secrets-operator/blob/d462e563feeefbf10dc0637834f08e82e1d3f0c1/LICENSE#L7 | |||
| min: v0.2.0 | |||
|
|
|||
| dissalowed_attributes: | |||
There was a problem hiding this comment.
Suggested change
| dissalowed_attributes: | |
| disallowed_attributes: |
There was a problem hiding this comment.
See also enterprise-contract/ec-policies#1046 .
|
I created #29 to replace this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cachi2 will set the
cachi2:pip:package:binaryproperty totruefor the dependencies from pip that contain binaries within them. This in conjunction with [PR#1030][1] will not allow those.Reference: https://issues.redhat.com/browse/EC-638
[1] enterprise-contract/ec-policies#1030