chore(tests): Move code in global test scope to inside beforeAll #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore(tests): Move code in global test scope to inside beforeAll
Problem:
When we need to run only a specific test (
it.only()
), we were seeing logs ofcreateHeadlessForm()
outside that test unit. That can cause a lot of noise if we want to debug only a specific unit test, but also seeing logs from other instances.Reason
That happens because we had 1 instance of
createHeadlessForm()
being called outside jest lifecycle.Solution
Moved that 1 instance in the global scope (inside
describe()
) to an isolated scope, usingbeforeAll()
How to test.
A simple way can be to add
console.log()
to inside thecreateHeadlessForm()
export function createHeadlessForm(jsonSchema, customConfig = {}) { + console.log('Hello!')
And then run only one test at your choise. Eg
it.only('returns empty result given no schema'
You'll see the logs saying "Hello" once. But if you go to main master and do the same thing, you'll see the logs twice (Because of the other global instance)