Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(providers): adding the Aurora native mainnet and testnet RPC #469

Merged
merged 1 commit into from
Jan 18, 2024
Merged

feat(providers): adding the Aurora native mainnet and testnet RPC #469

merged 1 commit into from
Jan 18, 2024

Conversation

geekbrother
Copy link
Contributor

@geekbrother geekbrother commented Jan 15, 2024 •
edited
Loading

Description

This PR adds the Aurora Mainnet and Testnet RPC as a new Aurora provider.

Resolves #463

How Has This Been Tested?

  1. Manually:
  • Start the server locally by cargo run.
  • Request the Aurora RPC locally by
curl -X POST "http://localhost:3000/v1?chainId=eip155:1313161554&projectId=XXX" --data '{"id":"1","jsonrpc":"2.0","method":"eth_chainId","params":[]}'
  1. CI

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Jan 15, 2024
@geekbrother geekbrother force-pushed the feat/adding_aurora branch 2 times, most recently from 08d8561 to 5d02c6d Compare January 15, 2024 12:03
geekbrother
geekbrother commented Jan 15, 2024
View reviewed changes
src/env/aurora.rs
"eip155:1313161554".into(),
(
"https://mainnet.aurora.dev".into(),
Weight::new(Priority::High).unwrap(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the priority HIGH by default for the native endpoint.

@geekbrother geekbrother marked this pull request as ready for review January 15, 2024 12:06
@geekbrother geekbrother requested a review from xav as a code owner January 15, 2024 12:06
@geekbrother geekbrother requested a review from arein January 15, 2024 12:06
arein
arein approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO easier to do the tests via the NodeJS tests going forward

chris13524
chris13524 approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Karkunow
Copy link

Can we merge this one? :)

@geekbrother
Copy link
Contributor Author

Can we merge this one? :)

Hello @Karkunow!
We are finishing testing our updated providers CI tests and this PR will be merged asap. ETA Jan.18

@geekbrother geekbrother merged commit 48b18c7 into master Jan 18, 2024
12 checks passed
@geekbrother geekbrother deleted the feat/adding_aurora branch January 18, 2024 10:48
@geekbrother geekbrother mentioned this pull request Jan 23, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris13524 chris13524 chris13524 approved these changes

@arein arein arein approved these changes

@xav xav Awaiting requested review from xav

Assignees

@geekbrother geekbrother

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Adding Aurora rpc to providers
4 participants
@geekbrother @Karkunow @arein @chris13524