feat: fungible metadata amount utils + get_route_ui_fields() FFI #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
force-pushed
the
feat/fungible-metadata-amount-utils
branch
from
8017600 to
e2f33b2
Compare
chris13524
force-pushed
the
feat/fungible-metadata-amount-utils
branch
from
e2f33b2 to
5eb523d
Compare
chris13524
changed the title
jakubuid
reviewed
Dec 6, 2024
jakubuid
reviewed
Dec 6, 2024
jakubuid
reviewed
Dec 6, 2024
jakubuid
approved these changes
Dec 6, 2024
llbartekll
reviewed
Dec 6, 2024
jakubuid
reviewed
Dec 6, 2024
jakubuid
approved these changes
Dec 9, 2024
…/fungible-metadata-amount-utils
geekbrother
reviewed
Dec 9, 2024
| serialize_with = "crate::utils::serialize_unit" | ||
| )] | ||
| #[serde(default = "default_unit")] | ||
| pub decimals: Unit, |
There was a problem hiding this comment.
I believe we can use U8 here instead?
There was a problem hiding this comment.
Why? I think we should use Unit since it's alloy's type to represent these decimals. It has built-in assertions that the value is less than 77, so we know it's a valid unit. Rust code can also have fewer error conditions when this type is already being used by calling code.
…com/reown-com/yttrium into feat/fungible-metadata-amount-utils
chris13524
force-pushed
the
feat/fungible-metadata-amount-utils
branch
from
91fc711 to
7ab64ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decimalsfield so Blockchain API can return thisto_[bridging_fee_]amount()utils to get formatted valuesget_route_ui_fields()FFI