send preflight results event when preflights fail #1553
Conversation
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
…ort-skipped-preflight-failures
…ort-skipped-preflight-failures
laverya
changed the title
…ort-skipped-preflight-failures
| } | ||
|
|
||
| func runHostPreflights(cmd *cobra.Command, hpf *v1beta2.HostPreflightSpec, proxy *ecv1beta1.ProxySpec, assumeYes bool) error { | ||
| func runHostPreflights(cmd *cobra.Command, hpf *v1beta2.HostPreflightSpec, proxy *ecv1beta1.ProxySpec, assumeYes bool, replicatedAPIURL string) error { |
There was a problem hiding this comment.
since this function is called from many different commands, wouldn't it be helpful to report which command was run? also, is it your intention to report for the run-preflights commands? and not related to this change, but why prompt at all for those commands?
There was a problem hiding this comment.
I have updated the reporting to include the command that was called (install, run-preflights, join etc)
There was a problem hiding this comment.
and not related to this change, but why prompt at all for those commands?
Because it's the same codepath, but we hide the 'skip-host-preflights' and 'ignore-host-preflight' flags on those commands, so there shouldn't be prompts (the code we're using expects the flags to exist, which is why they're there at all)
…eflight failure results
also add ignore-host-preflights and skip-host-preflights to join/run-preflights
…ort-skipped-preflight-failures
laverya
deleted the
laverya/sc-115699/report-skipped-preflight-failures
branch
* send preflight results event when preflights fail (#1553) * send preflight results event when failed preflights are bypassed * send preflight failure events whether or not they are bypassed * ? * send json, not go object * better handle 'no baseurl' case * report the entry command (install, run-preflights, etc) along with preflight failure results * mark ignore-host-preflights as hidden in install/run-preflights also add ignore-host-preflights and skip-host-preflights to join/run-preflights * Run host preflights as part of the install2 command * break cycle dep * add exclude_graphdriver_btrfs tag --------- Co-authored-by: Andrew Lavery <[email protected]>
What this PR does / why we need it:
When a preflight fails/warns, send a copy of the preflight results to our metrics endpoint.
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?