-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
send preflight results event when preflights fail #1553
Merged
laverya
merged 11 commits into
main
from
laverya/sc-115699/report-skipped-preflight-failures
Dec 5, 2024
Merged
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b65b349
send preflight results event when failed preflights are bypassed
laverya dc7a6ee
send preflight failure events whether or not they are bypassed
laverya 3f75bd4
Merge remote-tracking branch 'origin/main' into laverya/sc-115699/rep…
laverya 2869d6b
?
laverya b9751f2
Merge remote-tracking branch 'origin/main' into laverya/sc-115699/rep…
laverya a7056a4
Merge remote-tracking branch 'origin/main' into laverya/sc-115699/rep…
laverya 2ebc291
send json, not go object
laverya 16dc9ef
better handle 'no baseurl' case
laverya 2b2436f
report the entry command (install, run-preflights, etc) along with pr…
laverya e3130c7
mark ignore-host-preflights as hidden in install/run-preflights
laverya 21e3e42
Merge remote-tracking branch 'origin/main' into laverya/sc-115699/rep…
laverya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this function is called from many different commands, wouldn't it be helpful to report which command was run? also, is it your intention to report for the
run-preflights
commands? and not related to this change, but why prompt at all for those commands?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the reporting to include the command that was called (install, run-preflights, join etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it's the same codepath, but we hide the 'skip-host-preflights' and 'ignore-host-preflight' flags on those commands, so there shouldn't be prompts (the code we're using expects the flags to exist, which is why they're there at all)