Projeto Guiado 2 - Rafaella Fiel #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return self.livros | ||
|
|
||
| def emprestar_livros(self, livro: Livro): | ||
| livro.esta_emprestado = True |
There was a problem hiding this comment.
Olá Rafaella.
Arrasou entregando toda a atividade. Aqui nesse método acho que só a lógica pode ser aprimorada.
Aqui vc está definindo o objeto livro que recebeu de parametro como emprestado
Mas seria mais interessante a gente alterar o status do livro que está na nossa biblioteca, ou seja dentro de self.livros
| #autor_livro = "bell hooks" | ||
| livro = Livro("Tudo sobre o amor", "bell hooks") | ||
| self.biblioteca.emprestar_livros(livro) | ||
| self.assertTrue = () |
There was a problem hiding this comment.
Aqui nesse teste acho que ele está retornando um falso positivo. Quando executamos só self.assertTrue ele executa sem erros mas também não valida o que queremos :T
será que vc não está querendo validar o assertTrue com o seu alvo do teste? (o livro emprestado)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.