generated from reprograma/onX-sx-temaX
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Projeto Guiado 2 - Rafaella Fiel #24
Open
rafaellafiel
wants to merge
1
commit into
reprograma:main
Choose a base branch
from
rafaellafiel:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# Sistema de biblioteca | ||
# Adicionar, listar e emprestar livros | ||
from Livro import Livro | ||
|
||
class Biblioteca: | ||
"""Classe biblioteca""" | ||
def __init__(self): | ||
self.livros = [] | ||
|
||
def adicionar_livro(self, livro: Livro): | ||
if (not isinstance(livro, Livro)): | ||
raise TypeError(f"Esperado do valor {livro} do tipo {type(livro)}") | ||
self.livros.append(livro) | ||
|
||
def exibir_livros(self): | ||
return self.livros | ||
|
||
def emprestar_livros(self, livro: Livro): | ||
livro.esta_emprestado = True | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
class Livro: | ||
"""Classe livro""" | ||
def __init__(self, nome, autor): | ||
self.nome = nome | ||
self.autor = autor | ||
self.esta_emprestado = False |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
from unittest import TestCase | ||
from Biblioteca import Biblioteca | ||
from Livro import Livro | ||
|
||
class TestBiblioteca(TestCase): | ||
def setUp(self): | ||
self.biblioteca = Biblioteca() | ||
|
||
def test_init_deve_passar(self): | ||
# arrange e act | ||
#biblioteca = Biblioteca() | ||
# assert | ||
self.assertIsInstance(self.biblioteca.livros, list) | ||
|
||
def test_adicionar_livro_deve_passar(self): | ||
# arrange | ||
#biblioteca = Biblioteca() | ||
nome_livro = "Tudo sobre o amor" | ||
autor_livro = "bell hooks" | ||
livro = Livro(nome = nome_livro, autor = autor_livro) | ||
# act | ||
self.biblioteca.adicionar_livro(livro) | ||
# assert | ||
self.assertEqual(1, len(self.biblioteca.livros)) | ||
|
||
def test_adicionar_livro_nao_deve_inserir_numero(self): | ||
# arrange | ||
#biblioteca = Biblioteca() | ||
livro = 1988 | ||
# act e assert | ||
with self.assertRaises(TypeError): | ||
self.biblioteca.adicionar_livro(Livro) | ||
|
||
def test_exibir_livros_deve_passar(self): | ||
livro = Livro("Tudo sobre o amor", "bell hooks") | ||
self.biblioteca.adicionar_livro(livro) | ||
self.assertEqual([livro], self.biblioteca.exibir_livros()) | ||
|
||
def test_emprestar_livro(self): | ||
#nome_livro = "Tudo sobre o amor" | ||
#autor_livro = "bell hooks" | ||
livro = Livro("Tudo sobre o amor", "bell hooks") | ||
self.biblioteca.emprestar_livros(livro) | ||
self.assertTrue = () | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Aqui nesse teste acho que ele está retornando um falso positivo. Quando executamos só self.assertTrue ele executa sem erros mas também não valida o que queremos :T |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
from unittest import TestCase | ||
from Livro import Livro | ||
|
||
class TestLivro(TestCase): | ||
def test_init_deve_passar(self): | ||
# arrange | ||
nome = "pachinko" | ||
autor = "Min Jin Lee" | ||
# act | ||
livro = Livro(nome, autor) | ||
# assert | ||
self.assertEqual(nome, livro.nome) | ||
self.assertEqual(autor, livro.autor) | ||
self.assertEqual(False, livro.esta_emprestado) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Olá Rafaella.
Arrasou entregando toda a atividade. Aqui nesse método acho que só a lógica pode ser aprimorada.
Aqui vc está definindo o objeto livro que recebeu de parametro como emprestado
Mas seria mais interessante a gente alterar o status do livro que está na nossa biblioteca, ou seja dentro de self.livros