Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last "Next Incident" button redirects to a null incident #2695

Closed
pdcp1 opened this issue Mar 15, 2024 · 1 comment
Closed

Last "Next Incident" button redirects to a null incident #2695

pdcp1 opened this issue Mar 15, 2024 · 1 comment
Assignees
Labels
Type: Bug Something isn't working

Comments

@pdcp1
Copy link
Collaborator

pdcp1 commented Mar 15, 2024

As part of the testing of #2689 I found an edge-case test.

Steps to reproduce

  1. Go to the last incident (at this moment the last incident is https://incidentdatabase.ai/cite/652 )
  2. Scroll down and check the Next Incident button. It should be disabled
  3. Click that Next Incident button anyways
  4. It redirects to https://incidentdatabase.ai/cite/null/

The same happens with the first incident https://incidentdatabase.ai/cite/1/ and the Previous Incident button.

Notes

In addition to the disabled visual state, the button shouldn't be clickable (completely disabled)

@kepae
Copy link
Collaborator

kepae commented Jun 17, 2024

I believe this is now fixed.

@kepae kepae closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants