-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add next/previous incident buttons in cite header #2689
Add next/previous incident buttons in cite header #2689
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #2689 +/- ##
===========================================
- Coverage 86.31% 82.23% -4.09%
===========================================
Files 248 244 -4
Lines 8338 8228 -110
Branches 2625 2596 -29
===========================================
- Hits 7197 6766 -431
- Misses 1048 1346 +298
- Partials 93 116 +23 ☔ View full report in Codecov by Sentry. |
2 failed tests on run #2184 ↗︎
Details:
cypress/e2e/integration/cite.cy.js • 2 failed tests • Cypress e2e testsReview all test suite changes for PR #2689 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, it looks good to me. I recommend adding tests to these buttons on cite.cy.js
.
Please take into consideration this edge-case scenario for the first and last incident in the database.
FYI: I fixed it for the buttons at the bottom in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests to these new buttons. You can copy the test structure from this PR
47baab7
into
responsible-ai-collaborative:staging
First item of #2685.
Putting the links in the header to avoid taking up so much space.