Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add next/previous incident buttons in cite header #2689

Conversation

lmcnulty
Copy link
Collaborator

First item of #2685.

Putting the links in the header to avoid taking up so much space.

image

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.23%. Comparing base (2b8bf51) to head (3759062).
Report is 1 commits behind head on staging.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2689      +/-   ##
===========================================
- Coverage    86.31%   82.23%   -4.09%     
===========================================
  Files          248      244       -4     
  Lines         8338     8228     -110     
  Branches      2625     2596      -29     
===========================================
- Hits          7197     6766     -431     
- Misses        1048     1346     +298     
- Partials        93      116      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Mar 13, 2024

2 failed tests on run #2184 ↗︎

2 481 244 0 Flakiness 0

Details:

Add next/previous incident buttons in cite header
Project: aiid-site Commit: 375906294f
Status: Failed Duration: 17:31 💡
Started: Apr 24, 2024 3:54 PM Ended: Apr 24, 2024 4:11 PM
Failed  cypress/e2e/integration/cite.cy.js • 2 failed tests • Cypress e2e tests

View Output

Test Artifacts
Cite pages > Should disable Previous and Next incident buttons on first and last incidents Test Replay
Cite pages > Should disable Previous and Next incident buttons in header on first and last incidents Test Replay

Review all test suite changes for PR #2689 ↗︎

Copy link
Collaborator

@pdcp1 pdcp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it looks good to me. I recommend adding tests to these buttons on cite.cy.js.
Please take into consideration this edge-case scenario for the first and last incident in the database.

FYI: I fixed it for the buttons at the bottom in this PR

Copy link
Collaborator

@pdcp1 pdcp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests to these new buttons. You can copy the test structure from this PR

@lmcnulty lmcnulty merged commit 47baab7 into responsible-ai-collaborative:staging Apr 30, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants