-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set current page from URL param page #2460
Set current page from URL param page #2460
Conversation
❌ Deploy Preview for staging-aiid failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I would like to merge this after #2467 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #2460 +/- ##
===========================================
+ Coverage 85.83% 85.87% +0.03%
===========================================
Files 228 228
Lines 7377 7383 +6
Branches 2371 2370 -1
===========================================
+ Hits 6332 6340 +8
+ Misses 955 954 -1
+ Partials 90 89 -1 ☔ View full report in Codecov by Sentry. |
Passing run #1818 ↗︎
Details:
Review all test suite changes for PR #2460 ↗︎ |
🚀 Deployed to Netlify! ✅ Build Log: 🔗 Preview URL: https://pr-2460--staging-aiid.netlify.app |
We will merge once the tests pass. Please wait for #2592 to be merged and then merge |
@clari182 @cesarvarela looks good to update this with latest staging, test, and merge? |
@cesarvarela ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of the implementation but everything seems to be working so
URL: https://pr-2460--staging-aiid.netlify.app/