Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set current page from URL param page #2460

Merged

Conversation

clari182
Copy link
Collaborator

@clari182 clari182 commented Dec 1, 2023

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for staging-aiid failed.

Name Link
🔨 Latest commit 1caec14
🔍 Latest deploy log https://app.netlify.com/sites/staging-aiid/deploys/65aea3a35178ba0008788890

@clari182 clari182 marked this pull request as draft December 1, 2023 13:43
@clari182 clari182 marked this pull request as ready for review December 4, 2023 13:52
Copy link
Collaborator

@pdcp1 pdcp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cesarvarela
Copy link
Collaborator

cesarvarela commented Jan 9, 2024

I would like to merge this after #2467

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.87%. Comparing base (92f5ef4) to head (b9d7d48).

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2460      +/-   ##
===========================================
+ Coverage    85.83%   85.87%   +0.03%     
===========================================
  Files          228      228              
  Lines         7377     7383       +6     
  Branches      2371     2370       -1     
===========================================
+ Hits          6332     6340       +8     
+ Misses         955      954       -1     
+ Partials        90       89       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Jan 22, 2024

Passing run #1818 ↗︎

0 356 190 0 Flakiness 0

Details:

Set current page from URL param page
Project: aiid-site Commit: b9d7d482af
Status: Passed Duration: 15:09 💡
Started: Mar 12, 2024 1:34 PM Ended: Mar 12, 2024 1:49 PM

Review all test suite changes for PR #2460 ↗︎

Copy link

@cesarvarela
Copy link
Collaborator

cesarvarela commented Jan 25, 2024

We will merge once the tests pass. Please wait for #2592 to be merged and then merge staging here.

@kepae
Copy link
Collaborator

kepae commented Feb 8, 2024

@clari182 @cesarvarela looks good to update this with latest staging, test, and merge?

@clari182
Copy link
Collaborator Author

@cesarvarela ready for review

Copy link
Collaborator

@cesarvarela cesarvarela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of the implementation but everything seems to be working so :shipit:

@kepae

@kepae kepae merged commit 02508b0 into responsible-ai-collaborative:staging Mar 12, 2024
10 checks passed
@clari182 clari182 deleted the fix/discover-pages branch March 13, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants