Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reports table view #2691

Merged

Conversation

clari182
Copy link
Collaborator

@clari182 clari182 commented Mar 13, 2024

Test URL: https://pr-2691--staging-aiid.netlify.app/
Changes:

  • Added Issue Reports and Reports in the table view page
  • Removed /apps/reports page, now everything is in the table view page apps/incidents

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 56.75676% with 64 lines in your changes are missing coverage. Please review.

Project coverage is 85.34%. Comparing base (07656ef) to head (5e10229).

Files Patch % Lines
site/gatsby-site/src/pages/apps/incidents.js 64.47% 25 Missing and 2 partials ⚠️
site/gatsby-site/src/components/ui/Table.js 0.00% 14 Missing and 5 partials ⚠️
...gatsby-site/src/components/reports/ReportsTable.js 60.00% 14 Missing ⚠️
...by-site/src/components/incidents/IncidentsTable.js 55.55% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2691      +/-   ##
===========================================
- Coverage    85.81%   85.34%   -0.47%     
===========================================
  Files          228      227       -1     
  Lines         7394     7451      +57     
  Branches      2360     2393      +33     
===========================================
+ Hits          6345     6359      +14     
- Misses         962     1002      +40     
- Partials        87       90       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Mar 13, 2024

Passing run #2006 ↗︎

0 360 244 0 Flakiness 0

Details:

Merge pull request #2691 from clari182/feature/reports-table-view
Project: aiid-site Commit: a76b741695
Status: Passed Duration: 14:02 💡
Started: Apr 1, 2024 3:49 PM Ended: Apr 1, 2024 4:03 PM

Review all test suite changes for PR #2691 ↗︎

@clari182
Copy link
Collaborator Author

@kepae @datherton09
this is ready for review, let me know if the new implementation seems alright to you.

@datherton09
Copy link
Collaborator

@clari182 Clara, this is wonderful! Thank you so much!

One quick thing I was wondering about with sorting the issue reports by date is that I'm not entirely sure if it's actually sorting them in either ascending/descending order? (The ordering seems semi-haphazard? Or maybe I'm missing something!)

@clari182
Copy link
Collaborator Author

@datherton09 date filter and sort fixed! Ready for another round of testing

@datherton09
Copy link
Collaborator

@clari182 Really nice!! Thank you so much, Clara! :)

@kepae
Copy link
Collaborator

kepae commented Mar 29, 2024

Sorry, didn't finish my review here before merge conflicts came up! Will review shortly.

@kepae kepae merged commit a76b741 into responsible-ai-collaborative:staging Apr 1, 2024
7 of 10 checks passed
@clari182 clari182 deleted the feature/reports-table-view branch April 1, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants