Do not refresh token on every request and cache verified ones #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #3014 +/- ##
===========================================
- Coverage 96.79% 91.41% -5.39%
===========================================
Files 30 110 +80
Lines 8680 10971 +2291
Branches 121 882 +761
===========================================
+ Hits 8402 10029 +1627
- Misses 278 878 +600
- Partials 0 64 +64 ☔ View full report in Codecov by Sentry. |
kepae
reviewed
Aug 12, 2024
| async function getUserFromHeader(header: string, client: MongoClient) { | ||
| async function getTokenCache(token: string, client: MongoClient) { | ||
| const db = client.db('customData'); | ||
| const collection = db.collection('tokenCache'); |
There was a problem hiding this comment.
drive-by: let's discuss how to cache tokens before creating a DB collection for this.
|
In favor of #3220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For comparison:
https://staging-aiid.netlify.app/apps/submitted/
https://pr-3014--staging-aiid.netlify.app/apps/submitted/