-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add glowing aiid logo for emails #3123
Open
lmcnulty
wants to merge
1
commit into
responsible-ai-collaborative:staging
Choose a base branch
from
lmcnulty:add-email-template-logo-static
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add glowing aiid logo for emails #3123
lmcnulty
wants to merge
1
commit into
responsible-ai-collaborative:staging
from
lmcnulty:add-email-template-logo-static
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #3123 +/- ##
============================================
- Coverage 96.96% 36.27% -60.69%
============================================
Files 41 114 +73
Lines 9974 3096 -6878
Branches 186 1081 +895
============================================
- Hits 9671 1123 -8548
- Misses 303 1733 +1430
- Partials 0 240 +240 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The email template update PR currently embeds the logo image with a data url. This is not supported everywhere, and the easiest solution is just to add it as a static asset to the website and then link it in the email.