Feature/sidebar sub items #3181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #3181 +/- ##
===========================================
- Coverage 95.42% 95.29% -0.14%
===========================================
Files 80 78 -2
Lines 13066 13060 -6
Branches 444 445 +1
===========================================
- Hits 12468 12445 -23
- Misses 580 598 +18
+ Partials 18 17 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the sidebar functionality and update test selectors. The most important changes include modifications to the sidebar component to support expanded nodes, updates to test selectors, and improvements to the tree structure and node components.
Sidebar functionality improvements:
site/gatsby-site/src/components/sidebar/index.js: Added support for expanded nodes with localStorage persistence and toggle functions. [1] [2] [3] [4] [5]site/gatsby-site/src/components/sidebar/tree.js: Refactored tree structure to handle expanded nodes and added PropTypes validation.site/gatsby-site/src/components/sidebar/treeNode.js: Updated tree node component to handle expanded nodes and added keyboard accessibility. [1] [2] [3]Test selector updates:
site/gatsby-site/playwright/e2e/landingPage.spec.ts: Updated test selectors for sidebar elements.site/gatsby-site/playwright/e2e/navigation.spec.ts: Modified test selectors to ensure accurate element targeting.Other changes:
site/gatsby-site/tailwind.config.js: Added dynamic class safelisting for TailwindCSS.