Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring the translation process #3201

Open
wants to merge 35 commits into
base: staging
Choose a base branch
from

Conversation

pdcp1
Copy link
Collaborator

@pdcp1 pdcp1 commented Nov 6, 2024

This PR

badge

Deployment

We need to make sure that these env variables and secrets are setup in both environments staging and production:

  • secrets.MONGODB_TRANSLATIONS_CONNECTION_STRING
  • secrets.GOOGLE_TRANSLATE_API_KEY
  • vars.TRANSLATE_DRY_RUN

Example executions

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.45%. Comparing base (977b466) to head (740050e).

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #3201      +/-   ##
===========================================
- Coverage    95.46%   95.45%   -0.02%     
===========================================
  Files           80       76       -4     
  Lines        13066    13036      -30     
  Branches       520      439      -81     
===========================================
- Hits         12473    12443      -30     
- Misses         567      575       +8     
+ Partials        26       18       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@cesarvarela cesarvarela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test failing expected?

Translation Badges › Should be visible on an report card on the citation page if it was translated

@pdcp1
Copy link
Collaborator Author

pdcp1 commented Nov 19, 2024

Is this test failing expected?

Translation Badges › Should be visible on an report card on the citation page if it was translated

I just moved into e2e-full folder and now it uses the in-memory database. It passes ✅
@cesarvarela please review

Copy link
Collaborator

@cesarvarela cesarvarela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants