-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update email template for mailersend with clean HTML #3218
base: staging
Are you sure you want to change the base?
Update email template for mailersend with clean HTML #3218
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #3218 +/- ##
===========================================
- Coverage 94.81% 94.43% -0.38%
===========================================
Files 111 113 +2
Lines 13528 12720 -808
Branches 696 706 +10
===========================================
- Hits 12826 12012 -814
- Misses 674 688 +14
+ Partials 28 20 -8 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Please confirm with @cesarvarela if it would be better to merge now or after some of the changes he's making to the notifications logic.
Looks like it is safe to merge it $now |
Now updates all the email templates (except the user management ones). |
Supercedes #3099.
Light mode:
Also adds a script to test the template without running the whole site at
site/gatsby-site/src/scripts/sendEmailTest.js
.