Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update email template for mailersend with clean HTML #3218

Open
wants to merge 7 commits into
base: staging
Choose a base branch
from

Conversation

lmcnulty
Copy link
Collaborator

@lmcnulty lmcnulty commented Nov 13, 2024

Supercedes #3099.

image

Light mode:
image

Also adds a script to test the template without running the whole site at site/gatsby-site/src/scripts/sendEmailTest.js.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.43%. Comparing base (e6490c6) to head (281cc72).
Report is 15 commits behind head on staging.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #3218      +/-   ##
===========================================
- Coverage    94.81%   94.43%   -0.38%     
===========================================
  Files          111      113       +2     
  Lines        13528    12720     -808     
  Branches       696      706      +10     
===========================================
- Hits         12826    12012     -814     
- Misses         674      688      +14     
+ Partials        28       20       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@kepae kepae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Please confirm with @cesarvarela if it would be better to merge now or after some of the changes he's making to the notifications logic.

@cesarvarela
Copy link
Collaborator

Looks like it is safe to merge it $now

@lmcnulty
Copy link
Collaborator Author

Now updates all the email templates (except the user management ones).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants