-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix translations discrepancies #3219
base: staging
Are you sure you want to change the base?
Fix translations discrepancies #3219
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #3219 +/- ##
========================================
Coverage 95.46% 95.46%
========================================
Files 80 80
Lines 13066 13066
Branches 520 519 -1
========================================
Hits 12473 12473
- Misses 567 575 +8
+ Partials 26 18 -8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pdcp1 can you change "disrepencies" to "discrepancies"? Otherwise PR looks good!
Hi @technohippy, Since you were the one who initially added the first Japanese translations to the system, could you please take a look at the changes in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Waiting on @technohippy review of ja
to merge.
This PR addresses all discrepancies in translations and resolves any missing translations found in https://incidentdatabase.ai/meta/i18n
Preview link
https://pr-3219--staging-aiid.netlify.app/meta/i18n
Result