Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translations discrepancies #3219

Open
wants to merge 5 commits into
base: staging
Choose a base branch
from

Conversation

pdcp1
Copy link
Collaborator

@pdcp1 pdcp1 commented Nov 14, 2024

This PR addresses all discrepancies in translations and resolves any missing translations found in https://incidentdatabase.ai/meta/i18n

Preview link

https://pr-3219--staging-aiid.netlify.app/meta/i18n

Result

image

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.46%. Comparing base (977b466) to head (9e0d789).

Additional details and impacted files
@@           Coverage Diff            @@
##           staging    #3219   +/-   ##
========================================
  Coverage    95.46%   95.46%           
========================================
  Files           80       80           
  Lines        13066    13066           
  Branches       520      519    -1     
========================================
  Hits         12473    12473           
- Misses         567      575    +8     
+ Partials        26       18    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdcp1 pdcp1 marked this pull request as ready for review November 14, 2024 17:36
@pdcp1 pdcp1 requested a review from clari182 November 14, 2024 17:36
@clari182 clari182 self-requested a review November 14, 2024 18:17
Copy link
Collaborator

@clari182 clari182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pdcp1 can you change "disrepencies" to "discrepancies"? Otherwise PR looks good!

@pdcp1
Copy link
Collaborator Author

pdcp1 commented Nov 14, 2024

@pdcp1 can you change "disrepencies" to "discrepancies"? Otherwise PR looks good!

@clari182 done!

@pdcp1
Copy link
Collaborator Author

pdcp1 commented Nov 14, 2024

Hi @technohippy,

Since you were the one who initially added the first Japanese translations to the system, could you please take a look at the changes in the JA folder https://github.com/responsible-ai-collaborative/aiid/pull/3219/files? We would really appreciate your feedback on whether those translations make sense to you. Thank you!

Copy link
Collaborator

@clari182 clari182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Waiting on @technohippy review of ja to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants