Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move verification out into separate script to fix ARM64 use #294

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move verification out into separate script to fix ARM64 use #294

wants to merge 1 commit into from

Conversation

ell1e
Copy link
Contributor

@ell1e ell1e commented Nov 25, 2023

Some platforms don't have the clang sanitizer checks available that are used in the verification tests, currently on these the output files can't even be amalgamated. To fix this, separate amalgamation and verification so that the later can be skipped. Fixes #273

@ell1e ell1e mentioned this pull request Nov 25, 2023
Closed
@ell1e ell1e force-pushed the amalgamate_fix_arm64 branch from c090d7a to 68ad084 Compare November 25, 2023 14:04
@ell1e
Move verification out into separate script to fix ARM64 use
b8f5bb2 
Some platforms don't have the clang sanitizer checks available
that are used in the verification tests, currently on these
the output files can't even be amalgamated. To fix this, separate
amalgamation and verification so that the later can be skipped.
@ell1e ell1e force-pushed the amalgamate_fix_arm64 branch from 68ad084 to b8f5bb2 Compare November 25, 2023 14:12
@ell1e
Copy link
Contributor Author

ell1e commented Nov 26, 2023

If anyone knows why the fuzzing workflow suddenly can't find miniz_export.h anymore lemme know, I thought I hadn't moved anything around that could possibly break that (this file should still be generated by test.sh after my pull request is applied) so I don't understand what's going on there. Or is the workflow just generally broken? I can't quite make sense of it.

I would really love for this whole ARM64 musl-libc situation to get fixed soon, because it's just quite cumbersome to work around and I'm starting to shift a lot of my projects to more heavily support various ARM64 variants.

@ell1e ell1e mentioned this pull request Nov 26, 2023
Open
@ell1e
Copy link
Contributor Author

ell1e commented Jun 4, 2024

If a77af68 was the reason why CIFuzz / Fuzzing failed then maybe this is still good to go in. Sadly I don't know how to trigger the build again to test if it works now. Nevertheless, the underlying problem with platforms without libsanitize support seems to remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

./amalgamate.sh doesn't seem to be usable on ARM64 musl-libc Linux systems
1 participant
@ell1e