Skip to content

Commit

Permalink
Merge pull request #955 from MarekVCodasip/use-watchpoint-mask-macro
Browse files Browse the repository at this point in the history
target/riscv: Replace watchpoint value mask comparison value with macro.
  • Loading branch information
timsifive authored Nov 9, 2023
2 parents f119c1d + 2357237 commit 6f02884
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions src/target/riscv/riscv.c
Original file line number Diff line number Diff line change
Expand Up @@ -1375,10 +1375,7 @@ static void trigger_from_watchpoint(struct trigger *trigger,

int riscv_add_watchpoint(struct target *target, struct watchpoint *watchpoint)
{
// NOTE: typeof is needed because of upstream OpenOCD bug. This should be
// replaced by WATCHPOINT_IGNORE_DATA_VALUE_MASK once it is available
// See: https://review.openocd.org/c/openocd/+/7840
if (watchpoint->mask != ~(typeof(watchpoint->mask))0) {
if (watchpoint->mask != WATCHPOINT_IGNORE_DATA_VALUE_MASK) {
LOG_TARGET_ERROR(target, "Watchpoints on data values are not implemented");
return ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
}
Expand Down

0 comments on commit 6f02884

Please sign in to comment.