Skip to content

Commit

Permalink
[NFC] target/riscv: simplify code with MAX macros
Browse files Browse the repository at this point in the history
slightly improves readability
  • Loading branch information
zqb-all committed Oct 28, 2024
1 parent 9ff272e commit b7708c8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/target/riscv/riscv-013.c
Original file line number Diff line number Diff line change
Expand Up @@ -3566,7 +3566,7 @@ read_memory_abstract(struct target *target, target_addr_t address,
uint8_t *p = buffer;
int result = ERROR_OK;
bool updateaddr = true;
unsigned int width32 = (width < 32) ? 32 : width;
unsigned int width32 = MAX(width, 32);
for (uint32_t c = 0; c < count; c++) {
/* Update the address if it is the first time or aampostincrement is not supported by the target. */
if (updateaddr) {
Expand Down
2 changes: 1 addition & 1 deletion src/target/riscv/riscv.c
Original file line number Diff line number Diff line change
Expand Up @@ -4086,7 +4086,7 @@ static int parse_ranges(struct list_head *ranges, const char *tcl_arg, const cha
return ERROR_COMMAND_SYNTAX_ERROR;
}

high = high > low ? high : low;
high = MAX(high, low);

if (high > max_val) {
LOG_ERROR("Cannot expose %s register number %u, maximum allowed value is %u.", reg_type, high, max_val);
Expand Down

0 comments on commit b7708c8

Please sign in to comment.