Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target/riscv: re-apply patch do stop avoid warnings when a non-existent CSR is hidden #1118

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

aap-sc
Copy link
Collaborator

@aap-sc aap-sc commented Aug 21, 2024

the original fix was introduced in b201a5d but was lost in 3883b03

…nt CSR is hidden

the original fix was introduced in b201a5d but was lost in 3883b03
@aap-sc aap-sc requested review from en-sc and MarekVCodasip August 21, 2024 16:28
@aap-sc
Copy link
Collaborator Author

aap-sc commented Aug 21, 2024

@MarekVCodasip , @en-sc I'm going to wait till Friday and if no objections - I'll proceed with merging this. We already had this patch reviewed - it was occasionally lost in 3883b03

Copy link
Collaborator

@MarekVCodasip MarekVCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aap-sc aap-sc merged commit 8ea44aa into riscv-collab:riscv Aug 29, 2024
4 checks passed
@en-sc
Copy link
Collaborator

en-sc commented Sep 10, 2024

@aap-sc, this patch is not the same as b201a5d -- it changes the warning in riscv_reg_impl_expose_csrs() instead of the one in riscv_reg_impl_hide_csrs(). I'd like to revert it, since the commit message is extremely misleading.

The original issue (the one that b201a5d addressed) is still present in the current version:

if (!reg->exist) {
LOG_TARGET_WARNING(target,
"Not hiding CSR %d: register does not exist.",
csr_number);
continue;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants