Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target/riscv: early exit support for memory access operations #1134

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

fk-sc
Copy link
Contributor

@fk-sc fk-sc commented Sep 20, 2024

(1) Error code and skip_reason string were replaced with memory access
status. It allows to specify whether OpenOCD should exit the access
early.
(2) Slightly refactored read_memory and 'write_memory' functions.

@fk-sc
Copy link
Contributor Author

fk-sc commented Sep 20, 2024

@MarekVCodasip, @JanMatCodasip, please take a look

en-sc
en-sc previously approved these changes Sep 20, 2024
Copy link
Collaborator

@en-sc en-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (reviewed internally).

Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the refactor. Overall it looks good.

I have so far managed approx. 50 % of the review and will continue at the end of this week. I am sending the comments I have so far.

src/target/riscv/riscv.h Outdated Show resolved Hide resolved
src/target/riscv/riscv.c Outdated Show resolved Hide resolved
src/target/riscv/riscv.c Outdated Show resolved Hide resolved
src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved
src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved
src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved
src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved
src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved
src/target/riscv/riscv-013.c Show resolved Hide resolved
src/target/riscv/riscv-013.c Show resolved Hide resolved
@fk-sc fk-sc force-pushed the early-exit-support branch 2 times, most recently from ada32e0 to f94dd2c Compare September 25, 2024 13:48
Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the previous comments.

I have completed my review and am sending few last comments. I do not expect to have any more. If you can please check it out, thanks.

src/target/riscv/riscv-013.c Show resolved Hide resolved
src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved
src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved
src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved
src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved
@fk-sc fk-sc force-pushed the early-exit-support branch 2 times, most recently from 89034ab to 1060566 Compare September 27, 2024 09:21
(1) Error code and 'skip_reason' string were replaced with memory access
    status. It allows to specify whether OpenOCD should exit the access
    early.
(2) Slightly refactored 'read_memory' and 'write_memory' functions.

Checkpatch-ignore: MACRO_ARG_PRECEDENCE, MULTISTATEMENT_MACRO_USE_DO_WHILE
Checkpatch-ignore: TRAILING_SEMICOLON
Signed-off-by: Farid Khaydari <[email protected]>
@fk-sc fk-sc force-pushed the early-exit-support branch from 1060566 to 173086a Compare September 27, 2024 09:27
Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@en-sc en-sc merged commit 841b61a into riscv-collab:riscv Sep 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants