-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
target/riscv: early exit support for memory access operations #1134
Conversation
@MarekVCodasip, @JanMatCodasip, please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (reviewed internally).
d0f4a30
to
668d80e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the refactor. Overall it looks good.
I have so far managed approx. 50 % of the review and will continue at the end of this week. I am sending the comments I have so far.
ada32e0
to
f94dd2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing the previous comments.
I have completed my review and am sending few last comments. I do not expect to have any more. If you can please check it out, thanks.
89034ab
to
1060566
Compare
(1) Error code and 'skip_reason' string were replaced with memory access status. It allows to specify whether OpenOCD should exit the access early. (2) Slightly refactored 'read_memory' and 'write_memory' functions. Checkpatch-ignore: MACRO_ARG_PRECEDENCE, MULTISTATEMENT_MACRO_USE_DO_WHILE Checkpatch-ignore: TRAILING_SEMICOLON Signed-off-by: Farid Khaydari <[email protected]>
1060566
to
173086a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you.
(1) Error code and
skip_reason
string were replaced with memory accessstatus. It allows to specify whether OpenOCD should exit the access
early.
(2) Slightly refactored
read_memory
and 'write_memory' functions.