target/riscv: check other TAPs in `select_dmi()` #1146

en-sc · 2024-10-10T17:58:58Z

If some other TAP is not in BYPASS, an IR scan is needed to select BYPASS on that TAP.

Change-Id: Iae425a415109b1a853db3718762661877eea56e8

JanMatCodasip

Overall, this change looks all right to me. Could you please take a look at my comments and questions. I don't expect to have any more findings than what I have just posted.

Thank you.

src/target/riscv/riscv-013.c

If some other TAP is not in BYPASS, an IR scan is needed to select BYPASS on that TAP. Change-Id: Iae425a415109b1a853db3718762661877eea56e8 Signed-off-by: Evgeniy Naydanov <[email protected]>

JanMatCodasip

LGTM, thanks!

en-sc requested review from JanMatCodasip and MarekVCodasip October 10, 2024 17:58

en-sc self-assigned this Oct 10, 2024

JanMatCodasip reviewed Oct 16, 2024

View reviewed changes

src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved

src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved

src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved

en-sc force-pushed the en-sc/select-dmi-bypass branch from 225a7cf to 6c5ae52 Compare October 16, 2024 10:41

target/riscv: check other TAPs in select_dmi()

f3ed0ab

If some other TAP is not in BYPASS, an IR scan is needed to select BYPASS on that TAP. Change-Id: Iae425a415109b1a853db3718762661877eea56e8 Signed-off-by: Evgeniy Naydanov <[email protected]>

en-sc force-pushed the en-sc/select-dmi-bypass branch from 6c5ae52 to f3ed0ab Compare October 16, 2024 10:44

JanMatCodasip approved these changes Oct 16, 2024

View reviewed changes

en-sc merged commit bc68bd7 into riscv-collab:riscv Oct 18, 2024
4 checks passed

en-sc deleted the en-sc/select-dmi-bypass branch October 18, 2024 09:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

target/riscv: check other TAPs in `select_dmi()` #1146

target/riscv: check other TAPs in `select_dmi()` #1146

en-sc commented Oct 10, 2024

JanMatCodasip left a comment •

edited

Loading

JanMatCodasip left a comment

target/riscv: check other TAPs in select_dmi() #1146

target/riscv: check other TAPs in select_dmi() #1146

Conversation

en-sc commented Oct 10, 2024

JanMatCodasip left a comment • edited Loading

Choose a reason for hiding this comment

JanMatCodasip left a comment

Choose a reason for hiding this comment

target/riscv: check other TAPs in `select_dmi()` #1146

target/riscv: check other TAPs in `select_dmi()` #1146

JanMatCodasip left a comment •

edited

Loading