riscv: fix read/write virtual memory across page boundaries #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zqb-all
force-pushed
the
read-write-cross-page
branch
from
179aab2 to
d9c2ddb
Compare
zqb-all
force-pushed
the
read-write-cross-page
branch
2 times, most recently
from
866a4eb to
788e4f9
Compare
en-sc
requested changes
Oct 12, 2024
zqb-all
force-pushed
the
read-write-cross-page
branch
from
788e4f9 to
be0554a
Compare
zqb-all
force-pushed
the
read-write-cross-page
branch
3 times, most recently
from
2a4e2fe to
292873e
Compare
en-sc
reviewed
Oct 13, 2024
zqb-all
force-pushed
the
read-write-cross-page
branch
2 times, most recently
from
519ea7a to
a3c3b09
Compare
zqb-all
commented
Oct 13, 2024
|
@JanMatCodasip, @MarekVCodasip, please, take a look. |
JanMatCodasip
requested changes
Oct 24, 2024
There was a problem hiding this comment.
@zqb-all Thank you for the contribution. In principle, the change looks fine to me.
I have just several code-related suggestions (code style, log prints, TODO comments and similar). Please if you can look at them.
zqb-all
force-pushed
the
read-write-cross-page
branch
2 times, most recently
from
e62f4f4 to
ac5f95d
Compare
When read/write virtual addresses cross page boundaries, the physical addresses are not necessarily contiguous and need to call virt2phys again.
When mmu is disabled, simply call the physical read/write function
Reduce duplicate code
zqb-all
force-pushed
the
read-write-cross-page
branch
from
ac5f95d to
92d7a57
Compare
en-sc
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When read/write virtual addresses cross page boundaries, the physical addresses are not necessarily contiguous and need to call virt2phys again.