Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target/riscv: decrease modify_privilege function nesting level #1170

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

fk-sc
Copy link
Contributor

@fk-sc fk-sc commented Nov 19, 2024

No description provided.

@fk-sc
Copy link
Contributor Author

fk-sc commented Nov 20, 2024

@JanMatCodasip, @MarekVCodasip, could you take a look please?

JanMatCodasip
JanMatCodasip previously approved these changes Nov 20, 2024
Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

I am sending just few optional cosmetic suggestions.

src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved
src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved
src/target/riscv/riscv-013.c Show resolved Hide resolved
Restructured modify_privilege function to decrease nesting level

Signed-off-by: Farid Khaydari <[email protected]>
Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@en-sc en-sc merged commit eb1ecd7 into riscv-collab:riscv Nov 26, 2024
4 checks passed
@fk-sc fk-sc deleted the fk-sc/priv-mod branch November 29, 2024 12:26
@fk-sc fk-sc restored the fk-sc/priv-mod branch November 29, 2024 12:26
@fk-sc fk-sc deleted the fk-sc/priv-mod branch November 29, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants