Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF16 tests #395

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

BF16 tests #395

wants to merge 3 commits into from

Conversation

adlr
Copy link

@adlr adlr commented Oct 4, 2023

Description

First cut of tests for BF16. I would like to get community feedback on these, either in this change or the other supporting changes:

riscv-software-src/riscv-isac#77
riscv-software-src/riscv-ctg#82

Related Issues

NA

Ratified/Unratified Extensions

  • Ratified
  • Unratified

List Extensions

Zfbfmin, Zvfbfmin Zvfbfwma

https://github.com/riscv/riscv-bfloat16/releases/download/20230629/riscv-bfloat16.pdf

Reference Model Used

  • SAIL
  • Spike
  • Other - < SPECIFY HERE >

Mandatory Checklist:

  • All tests are compliant with the test-format spec present in this repo ?
  • Ran the new tests on RISCOF with SAIL/Spike as reference model successfully ?
  • Ran the new tests on RISCOF in coverage mode
  • Link to Google-Drive folder containing the new coverage reports (See this for more info): < SPECIFY HERE >
  • Link to PR in RISCV-ISAC from which the reports were generated : Changes to support BF16 riscv-software-src/riscv-isac#77
  • Changelog entry created with a minor patch

Optional Checklist:

  • RISCV-V CTG PR link if tests were generated using it : < SPECIFY HERE >
  • Were the tests hand-written/modified ?
  • Have you run these on any hard DUT model ? Please specify name and provide link if possible in the description
  • If you have modified arch_test.h Please provide a detailed description of the changes in the Description section above.

@allenjbaum
Copy link
Collaborator

Please change this as a pull into the dev branch instead of the main branch to avoid merge issues

#else
#define FLREG flq
#define FSREG fsq
#define FREGWIDTH 16
#endif

#if ZFINX==1
#define FLREG ld
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why you are defining FLREG to be a 64b load for Zfinx? Note that this definition must also work for an RV32_Zfinx which doesn't implement ld, which is RV64 only

@jamesbeyond jamesbeyond changed the base branch from main to dev May 28, 2024 16:57
@UmerShahidengr
Copy link
Collaborator

@adlr are you still working on BF16? I have closed your PR at ctg because of the conflicts with Zfa coverpoints. Please take a look at the coverpoints, also deliver the coverpoints and ACTs in a single PR. Apologies any inconvenience.

@adlr
Copy link
Author

adlr commented Jul 19, 2024

Hi Umer, no worries at all! I haven't been working on BF16 for a while and I'm pretty preoccupied with a number of other things. If someone wants to take this over and make the changes, please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants